Commits on Oct 30, 2024

1. Ensure FlutterDesktopViewControllerState declares default destructor …

   types containing std::unique_ptr to incomplete types require a destructor to be
   defined as the size is unavailable, otherwise the following error is raised at
   compile time:
   
   /usr/lib/gcc/aarch64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
     91 |       _GLIBCXX23_CONSTEXPR
     92 |       void
     93 |       operator()(_Tp* __ptr) const
        |       `- note: in instantiation of member function 'std::default_delete<flutter::FlutterELinuxView>::operator()' requested here
     94 |       {
     95 | 	static_assert(!is_void<_Tp>::value,
     96 | 		      "can't delete pointer to incomplete type");
     97 | 	static_assert(sizeof(_Tp)>0,
        |                `- error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
     98 | 		      "can't delete pointer to incomplete type");
     99 | 	delete __ptr;
   
   Signed-off-by: Luke Howard <[email protected]>

   

   lhoward committed Oct 30, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for e85e55b
   • Browse repository at this point

   Copy the full SHA

   e85e55b View commit details

   Browse the repository at this point in the history