Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert default sum explain tests to new explain setup. #1485

Closed
shahzadlone opened this issue May 10, 2023 · 0 comments · Fixed by #1489
Closed

Convert default sum explain tests to new explain setup. #1485

shahzadlone opened this issue May 10, 2023 · 0 comments · Fixed by #1489
Assignees
@shahzadlone
Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Milestone
DefraDB v0.5.1

Comments

@shahzadlone
Copy link
Member

Convert default sum explain tests to new explain setup.

More info in parent ticket: #953
@shahzadlone shahzadlone added area/testing Related to any test or testing suite code quality Related to improving code quality labels May 10, 2023
@shahzadlone shahzadlone added this to the DefraDB v0.5.1 milestone May 10, 2023
@shahzadlone shahzadlone self-assigned this May 10, 2023
@shahzadlone shahzadlone mentioned this issue May 10, 2023
Merged
shahzadlone added a commit that referenced this issue May 11, 2023
@shahzadlone
test: Convert explain sum tests to new explain setup (#1489)
864b3db 
## Relevant issue(s)
- Part of #953
- Resolves #1485

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. #953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain sum tests.
- Splits sum join tests in a separate file.
shahzadlone added a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@shahzadlone
test: Convert explain sum tests to new explain setup (sourcenetwork#1489
81d9249 
)

## Relevant issue(s)
- Part of sourcenetwork#953
- Resolves sourcenetwork#1485

## Description
Continue converting explain tests to the new explain setup before we can
integrate the entire setup to the new action-based setup. sourcenetwork#953 Has a lot
more detail on the entire plan.

- This PR converts all the default explain sum tests.
- Splits sum join tests in a separate file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzadlone shahzadlone

Labels
area/testing Related to any test or testing suite code quality Related to improving code quality
Projects
None yet
Milestone
DefraDB v0.5.1
Development

Successfully merging a pull request may close this issue.

test: Convert explain sum tests to new explain setup shahzadlone/defradb
1 participant
@shahzadlone