refactor: Purge all println and ban it #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here they are actually hidding what is actually untested
Instead of println
AndrewSisley
added
refactor
Codecov Report
@@ Coverage Diff @@
## develop #253 +/- ##
===========================================
- Coverage 58.57% 58.49% -0.09%
===========================================
Files 103 103
Lines 9846 9834 -12
===========================================
- Hits 5767 5752 -15
- Misses 3449 3454 +5
+ Partials 630 628 -2
|
|
This makes the benchmarks output a lot of logs if |
It does? Cheers for checking - will have a look - thought that would be the same as before (maybe it is lol?) |
Is doing in dev branch - will merge this after creating a new ticket to fix the bench spam: |
This was referenced Mar 1, 2022
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Use logger in bench package * Log command result instead of println * Remove printlns from db_test Here they are actually hidding what is actually untested * Write to log in db.printstore Instead of println * Use logger in db.tests * Delete println * Ban fmt.PrintX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #242
Commits are pretty broken down - more involved/controversial changes should have there own commit, with
Delete printlncontaining the benign.Please speak out if you have concerns, this is very much a proposal (with my vote for it atm). Not a problem if this is rejected.