Handle ENV flags properly (parse the string value)

[shahzadlone]

Here is a snippet of what we have in tests/integration/utils.go:

// We use environment variables instead of flags `go test ./...` throws for all packages
//  that don't have the flag defined
_, badgerInMemory = os.LookupEnv(memoryBadgerEnvName)
_, badgerFile = os.LookupEnv(fileBadgerEnvName)
databaseDir, _ = os.LookupEnv(fileBadgerPathEnvName)
_, mapStore = os.LookupEnv(memoryMapEnvName)
_, setupOnly = os.LookupEnv(setupOnlyEnvName)
_, detectDbChanges = os.LookupEnv(detectDbChangesEnvName)
repository, repositorySpecified := os.LookupEnv(repositoryEnvName)

Here is the what os.LookupEnv does:

// LookupEnv retrieves the value of the environment variable named
// by the key. If the variable is present in the environment the
// value (which may be empty) is returned and the boolean is true.
// Otherwise the returned value will be empty and the boolean will
// be false.

In other words only checks for the existence of the env variable without checking it's value.

For example: DEFRA_DETECT_DATABASE_CHANGES=true and DEFRA_DETECT_DATABASE_CHANGES=false are treated the same.

[orpheuslummis]

I agree that it is clearer to use values (true,false) of the env variables, rather than their existence.
That said, AFAIK the status quo is achieves the same effect but by determining the boolean via existence/non-existence rather than by defining value.
Therefore, I don't it as an issue.