ci: Reduce test resource usage and test with file db #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #791 +/- ##
===========================================
+ Coverage 59.11% 59.13% +0.01%
===========================================
Files 153 153
Lines 16977 16977
===========================================
+ Hits 10036 10039 +3
+ Misses 6023 6021 -2
+ Partials 918 917 -1
|
shahzadlone
approved these changes
Sep 13, 2022
fredcarle
approved these changes
Sep 14, 2022
| @@ -378,6 +378,8 @@ func ExecuteQueryTestCase( | |||
| assert.Fail(t, "Expected an error however none was raised.", test.Description) | |||
| } | |||
| } | |||
|
|
|||
| dbi.db.Close(ctx) | |||
shahzadlone
reviewed
Sep 14, 2022
Makefile
Outdated
| @@ -110,6 +110,10 @@ clean\:test: | |||
| test: | |||
| gotestsum --format pkgname -- ./... -race -shuffle=on | |||
|
|
|||
| .PHONY: test\:ci | |||
| test\:ci: | |||
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true gotestsum --format pkgname -- ./... -race -shuffle=on | |||
There was a problem hiding this comment.
suggestion: Keep the verbosity as we had before? to show the name of each test.
Suggested change
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true gotestsum --format pkgname -- ./... -race -shuffle=on | |
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true gotestsum --format testname -- ./... -race -shuffle=on |
shahzadlone
reviewed
Sep 14, 2022
Makefile
Outdated
| @@ -110,6 +110,10 @@ clean\:test: | |||
| test: | |||
| gotestsum --format pkgname -- ./... -race -shuffle=on | |||
|
|
|||
| .PHONY: test\:ci | |||
| test\:ci: | |||
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true gotestsum --format pkgname -- ./... -race -shuffle=on | |||
There was a problem hiding this comment.
suggestion: here is another suggestion similar to the previous one but cleaner. As long as this works for MacOS too.
Suggested change
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true gotestsum --format pkgname -- ./... -race -shuffle=on | |
| DEFRA_BADGER_MEMORY=true DEFRA_BADGER_FILE=true $(MAKE) test:names |
There was a problem hiding this comment.
cheers, will change
There was a problem hiding this comment.
@AndrewSisley ping me when you push the change and I'll test on MacOS.
There was a problem hiding this comment.
Nice, thanks for checking pre-merge :)
AndrewSisley
force-pushed
the
sisley/fix/I682-im-file-tests
branch
from
d591e94
to
49aff4c
Compare
AndrewSisley
force-pushed
the
sisley/fix/I682-im-file-tests
branch
from
49aff4c
to
4734a37
Compare
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Close database instance once finished with it * Run CI tests on IM and file databases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #682
Description
Closes databases once use has finished, massively reducing peak memory and bypassing the issues seen when maxing out mem consumption.
Also changes the ci tests to run with badger IM and file, instead of just IM.
Related issue #684 is deemed out of scope.
How has this been tested?
Tested the db.Closing issue by hard coding the internal bools to always run with IM and file. Tested the ci environment vars by hardcoding the file db to panic on init.