Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Option out of client #853

Closed
AndrewSisley opened this issue Sep 22, 2022 · 2 comments · Fixed by #939
Closed

Move Option out of client #853

AndrewSisley opened this issue Sep 22, 2022 · 2 comments · Fixed by #939
Assignees
@fredcarle
Labels
code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Comments

@AndrewSisley
Copy link
Contributor

It needs to be public, but also needs to be used internally and this is starting to cause problems. Should be move to a new 'public' package (either on its own, or one for similar stuff like enumerable).
@AndrewSisley AndrewSisley added refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels Sep 22, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Sep 22, 2022
@AndrewSisley AndrewSisley mentioned this issue Sep 22, 2022
Merged
@AndrewSisley
Copy link
Contributor Author

Have a quick look here and consider renaming something semi-related when doing #834 (comment)

@AndrewSisley AndrewSisley mentioned this issue Sep 22, 2022
Closed
@AndrewSisley AndrewSisley self-assigned this Sep 22, 2022
@AndrewSisley
Copy link
Contributor Author

Looked at moving it, and them remembered it would cause hassle for defra users as they'd have to import an extra package. Returning to backlog and will pick this up again if it becomes a nuisance again

@AndrewSisley AndrewSisley removed their assignment Sep 22, 2022
@fredcarle fredcarle self-assigned this Nov 11, 2022
@fredcarle fredcarle mentioned this issue Nov 13, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Nov 23, 2022
@fredcarle
chore: Move Option and Enumerable to immutables (#939)
5e28187 
Relevant issue(s)
Resolves #854
Resolves #853

Description
This PR adds no new code. It's simply moving or renaming things. Mainly, the Option and Enumerable types are moved the external immutable package and the UpdateEvent is moved to the events package are renamed Update.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
chore: Move Option and Enumerable to immutables (sourcenetwork#939)
6d3a58d 
Relevant issue(s)
Resolves sourcenetwork#854
Resolves sourcenetwork#853

Description
This PR adds no new code. It's simply moving or renaming things. Mainly, the Option and Enumerable types are moved the external immutable package and the UpdateEvent is moved to the events package are renamed Update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fredcarle fredcarle

Labels
code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Move Option and Enumerable to immutables sourcenetwork/defradb
2 participants
@fredcarle @AndrewSisley