Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Enumerable out of core #854

Closed
AndrewSisley opened this issue Sep 22, 2022 · 1 comment · Fixed by #939
Closed

Move Enumerable out of core #854

AndrewSisley opened this issue Sep 22, 2022 · 1 comment · Fixed by #939
Labels
code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components

Comments

@AndrewSisley
Copy link
Contributor

Similar to #853 but doesn't really need to be public atm (so this is much less important and we might not want to do this)
@AndrewSisley AndrewSisley added refactor This issue specific to or requires *notable* refactoring of existing codebases and components code quality Related to improving code quality labels Sep 22, 2022
@AndrewSisley AndrewSisley added this to the DefraDB v0.4 milestone Sep 22, 2022
@AndrewSisley
Copy link
Contributor Author

I miss-remembered, is already a child package of core and is good there

@AndrewSisley AndrewSisley closed this as not planned Won't fix, can't repro, duplicate, stale Sep 23, 2022
@fredcarle fredcarle mentioned this issue Nov 13, 2022
Merged
4 tasks
fredcarle added a commit that referenced this issue Nov 23, 2022
@fredcarle
chore: Move Option and Enumerable to immutables (#939)
5e28187 
Relevant issue(s)
Resolves #854
Resolves #853

Description
This PR adds no new code. It's simply moving or renaming things. Mainly, the Option and Enumerable types are moved the external immutable package and the UpdateEvent is moved to the events package are renamed Update.
shahzadlone pushed a commit to shahzadlone/defradb that referenced this issue Feb 23, 2024
@fredcarle
chore: Move Option and Enumerable to immutables (sourcenetwork#939)
6d3a58d 
Relevant issue(s)
Resolves sourcenetwork#854
Resolves sourcenetwork#853

Description
This PR adds no new code. It's simply moving or renaming things. Mainly, the Option and Enumerable types are moved the external immutable package and the UpdateEvent is moved to the events package are renamed Update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Related to improving code quality refactor This issue specific to or requires *notable* refactoring of existing codebases and components
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Move Option and Enumerable to immutables sourcenetwork/defradb
1 participant
@AndrewSisley