test: Add P2P tests for relational docs #1042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewSisley
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1042 +/- ##
===========================================
- Coverage 58.02% 57.95% -0.08%
===========================================
Files 174 174
Lines 19563 19563
===========================================
- Hits 11352 11337 -15
- Misses 7215 7227 +12
- Partials 996 999 +3
|
AndrewSisley
force-pushed
the
sisley/test/I1027-test-p2p-relational
branch
from
80fe49c
to
234742c
Compare
No tests have changed in this commit, they have just moved and the collection index added to the relevant test case properties.
Updates for 'Creates' documents were incorrectly waited for, resulting in false negative test results.
shahzadlone
pushed a commit
that referenced
this pull request
Apr 13, 2023
* Remove unused property * Allow wait group to complete on timeout * Move existing tests to simple dir * Pass schema in as param No tests have changed in this commit, they have just moved and the collection index added to the relevant test case properties. * Correctly calculate expected waits for peers Updates for 'Creates' documents were incorrectly waited for, resulting in false negative test results. * Add one to many p2p tests
shahzadlone
pushed a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
* Remove unused property * Allow wait group to complete on timeout * Move existing tests to simple dir * Pass schema in as param No tests have changed in this commit, they have just moved and the collection index added to the relevant test case properties. * Correctly calculate expected waits for peers Updates for 'Creates' documents were incorrectly waited for, resulting in false negative test results. * Add one to many p2p tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #1027
Description
Adds P2P tests for relational docs. Only a couple of useful tests actually came to mind for now, but it seems likely that they will be expanded upon in the future (particularly when introducing Lens) - the changes to the framework permitting that should make that a little easier.
No prod bugs found, although it is possible that
TestP2POneToManyPeerWithCreateUpdateLinkingSyncedDocToUnsyncedDocis only passing due to the probable-oddness documented byTestMutationCreateOneToOneNoChild.