test: Convert mutation explain tests to new explain setup #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
area/testing
shahzadlone
force-pushed
the
test/convert-default-mutation-explain-tests
branch
from
f8e4cf5
to
326b8c9
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1416 +/- ##
===========================================
- Coverage 72.28% 72.19% -0.10%
===========================================
Files 185 185
Lines 18160 18160
===========================================
- Hits 13127 13110 -17
- Misses 4004 4018 +14
- Partials 1029 1032 +3 |
fredcarle
reviewed
Apr 28, 2023
shahzadlone
force-pushed
the
test/convert-default-mutation-explain-tests
branch
from
326b8c9
to
eeaee3f
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…ork#1416) -Resolves sourcenetwork#1417 - Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. sourcenetwork#953 Has a lot more detail on the entire plan. - This PR converts all the default mutation explain tests to the new explain setup. - Splits delete tests into two files one with error and without. - Splits multi tests from single function into separate test functions (easier to maintain and debug). - Removes some tests that provide no value wrt to non-execution explain tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
Continue converting explain tests to the new explain setup before we can integrate the entire setup to the new action based setup. #953 Has a lot more detail on the entire plan.
This PR converts all the default mutation explain tests to the new explain setup.