test: Convert explain group tests to new explain setup #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - Remove the utility helper that we don't need anymore. - Add a fixture for empty group childSelects case for Author.
shahzadlone
added
area/testing
Codecov Report
@@ Coverage Diff @@
## develop #1537 +/- ##
===========================================
+ Coverage 72.10% 72.15% +0.04%
===========================================
Files 185 185
Lines 18295 18295
===========================================
+ Hits 13192 13201 +9
+ Misses 4060 4055 -5
+ Partials 1043 1039 -4 |
That seems like an independent issue to this one. |
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Feb 23, 2024
…#1537) ## Relevant issue(s) - Part of sourcenetwork#953 - Resolves sourcenetwork#1536 ## Description This PR is the last PR for default explain test conversions, this PR converts the remaining group tests. - This PR converts all the default explain group tests. - Separates some tests into their group child select cases. - Added a few tests where there was a test gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Description
This PR is the last PR for default explain test conversions, this PR converts the remaining group tests.
Note: One more PR after this to convert the simple tests and then the integration to the new testing framework with the new explain testing setup can be done.