Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add query name to CSV output of sbt categorize #421

Merged
merged 3 commits into from
Mar 9, 2018

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Feb 24, 2018

Adds another column to the csv output for sourmash categorize for the query name. Fixes #132.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@ctb ctb changed the title [MRG] add query name to CSV output of sbt categorize [WIP] add query name to CSV output of sbt categorize Feb 24, 2018
@codecov-io
Copy link

codecov-io commented Feb 24, 2018

Codecov Report

Merging #421 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files          32       32           
  Lines        4824     4824           
  Branches       36       36           
=======================================
  Hits         4345     4345           
  Misses        478      478           
  Partials        1        1
Impacted Files Coverage Δ
sourmash_lib/commands.py 90.85% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 700fc40...64e6116. Read the comment docs.

@ctb ctb changed the title [WIP] add query name to CSV output of sbt categorize [MRG] add query name to CSV output of sbt categorize Mar 9, 2018
@ctb
Copy link
Contributor Author

ctb commented Mar 9, 2018

ready for review!

@ctb ctb mentioned this pull request Mar 9, 2018
Copy link
Contributor

@standage standage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough to me!

@standage standage merged commit 7067827 into master Mar 9, 2018
@standage standage deleted the add/names_to_categorize branch March 9, 2018 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants