-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] add selector framework to Index, and moltype property to MinHash
object
#936
Conversation
(FWIW I'm thinking of moving the |
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 91.89% 91.58% -0.32%
==========================================
Files 71 71
Lines 5021 5049 +28
==========================================
+ Hits 4614 4624 +10
- Misses 407 425 +18
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
MinHash
object
I think this is ready for a first round of comments, @luizirber, if you are interested :) |
@@ -566,16 +566,19 @@ def is_molecule_type(self, molecule): | |||
"""Check if this MinHash is a particular human-readable molecule type. | |||
|
|||
Supports 'protein', 'dayhoff', 'hp', 'DNA'. | |||
@CTB deprecate for 4.0? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. See #751 for longer discussion, especially #751 (comment)
…d_index_selectors
…rmash into refactor/add_index_selectors
(remaining comments moved to new issues) |
When working on #809 I decided to try adding a function
Index.select(ksize=ksize, moltype=moltype, ...)
that would return a version of the Index that contained only signatures that matched those requirements. I also added amoltype
property to theMinHash
class.These changes are more general than #809 and touch on a few other issues, like #599, and deserve to be tested and reviewed separately, so I'm breaking them out here.
make test
Did it pass the tests?make coverage
Is the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?