Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined #936, #942, and #946 #950

Closed
wants to merge 58 commits into from
Closed

Combined #936, #942, and #946 #950

wants to merge 58 commits into from

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 18, 2020

This is a combination of #936, #942, and #946 - I wanted to see if the combined tests passed, and there were a few conflicts to resolve, hence this branch. I thought it'd be nice once all three were approved.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

ctb and others added 30 commits April 6, 2020 09:22
Co-Authored-By: Luiz Irber <[email protected]>
ctb added 27 commits April 15, 2020 15:18
@codecov
Copy link

codecov bot commented Apr 18, 2020

Codecov Report

Merging #950 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #950   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files          71       71           
  Lines        5066     5066           
=======================================
  Hits         4627     4627           
  Misses        439      439           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e691d65...e691d65. Read the comment docs.

@ctb ctb closed this Apr 18, 2020
@ctb ctb deleted the combine/936_946_942 branch April 18, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant