windows_package uses 'returns' not 'source_codes'

[jessepiccolo]

https://docs.chef.io/resource_windows_package.html

[descention]

I'd like to recommend a fix for backwards compatibility. https://github.com/criteo-cookbooks/ms_dotnet/pull/43/files#diff-a7d2eeb2d086b81cd0d199ea024b68e3R80

[atikhono]

@sneal Could you please have a look? This breaks the VS cookbook with windows cookbook >= 3.0.0.
windows_package is a part of check-client 12.6. The current state VS cookbook fails with:

=============================================================
           Error executing action `install` on resource 'visualstudio_edition[visualstudio]'
=============================================================
           NoMethodError
           -------------
           undefined method `success_codes' for Chef::Resource::WindowsPackage

install and edition providers. They replaced success_codes functionality with returns.

As for myself, no point in keeping compatibility with an old chef-client. Those who need it can lock themselves to an old visualstudio cookbook. Otherwise, the fix would be this (as suggested by @descention):

-        success_codes [0, 127, 3010]
+        success_codes [0, 127, 3010] if respond_to? :success_codes
+        returns [0, 127, 3010] if respond_to? :returns

[jbontech]

I also have same issue could u pls give ma workaround for this .

[sneal]

How about this?

• Finish and merge Visual Studio 2017 and network installs #11
• Merge this PR
• Drop support for older Chef versions
• Bump the cookbook major version

[spotlesscoder]

Why hasn't this been merged yet?

[martinmosegaard]

Ping!

[elmic11111]

Ping

[chaim1221]

Hi there, I fixed part of this in #17 but you found one locations I didn't quite get. One line change, and apparently it was long enough ago that #18 wasn't an issue ;) –merged.