Visual Studio 2017 and network installs #11

taliesins · 2017-05-02T15:47:45Z

Added Visual Studio 2017
Added network install feature for offline cache (there is no ISO for Visual Studio 2017)

…ork or local install. This means we don't want to extract or clean Visual Studio ISO.

…nstaller_file. The installer_file could be the path the full path to the network install

… use the installer_exe path only

Add ability to install via web installer

… null

--all Optional: Whether to install all workloads and components for a product. --allWorkloads Optional: Installs all workloads and their required components, no recommended or optional components. --includeRecommended Optional: Includes the recommended components for any workloads that are installed, but not the optional components. The workloads are specified either with --allWorkloads or --add. --includeOptional Optional: Includes the optional components for any workloads that are installed, but not the recommended components. The workloads are specified either with --allWorkloads or --add.

…commandline and its already installed. Perhaps passing in all the options will stop that.

steveruddell · 2017-05-26T15:06:46Z

@sneal what needs to be done by @taliesins to unblock this and get it merged?

sneal · 2017-05-26T16:49:32Z

@steveruddell We need to fix the RuboCop warnings so the build passes. Ideally we replace RuboCop with cookstyle, similar to what was done here.

taliesins · 2017-05-28T23:33:20Z

@sneal what would you like me to do to get this merged :>

Fixed RuboCop Errors

ryangribble · 2017-08-21T20:40:35Z

Did you have a working example of installing from the network install cache location @taliesins ?

Im having trouble actually getting this working.

Apart from the fact that I have credential/authentication issues in accessing the UNC location from chef (should this cookbook allow attributes to be specified for user/password and then use a powershell or mount resource to enable access to the location, or is that left up to the consuming users to do before they call the resource from this cookbook?), I also cant seem to actually get chef to try and execute the package installer in-situ from the network location.

When specifying the installer_path as \\\\server,domain\path\to\installer.exe the chef run ends up executing a blank command (eg cmd /c /wait "" --silent etc) and when specifying installer_path as file://server.domain/path/to/installer.exe it seems the package resource attempts to download the exe locally which would then result in it not actually using any of the cached packages on the network share.

spotlesscoder · 2017-10-02T12:20:50Z

What's the status here? can't wait to get VS 2017 support

taliesins · 2017-10-05T09:11:28Z

@ryangribble I added sample usage to read me https://github.com/taliesins/visualstudio/blob/NetworkInstall/README.md

node.override['visualstudio']['version'] = '2017' node.override['visualstudio']['edition'] = 'professional' node.override['visualstudio']['source'] = '' node.override['visualstudio']['2017']['professional']['default_source'] = '' node.override['visualstudio']['2017']['professional']['source'] = '' node.override['visualstudio']['2017']['professional']['filename'] = '' node.override['visualstudio']['2017']['professional']['checksum'] = nil node.override['visualstudio']['2017']['professional']['installer_file'] = '//myartifactrepo/visualstudio/vs_professional.exe'

ryangribble · 2017-10-05T09:17:55Z

I'm pretty sure that's what I tried but as I mentioned it uses the remote_file resource which tries to download the installer file and thus isn't running it "in situ" from the network cache location (and therefore doesn't use any of the cached workloads)?

Sauraus · 2017-11-07T01:41:22Z

attributes/default.rb

@@ -40,3 +40,4 @@
 include_attribute 'visualstudio::vs2012'
 include_attribute 'visualstudio::vs2013'
 include_attribute 'visualstudio::vs2015'
+include_attribute 'visualstudio::vs2017'


This is redundant, the chef-client run merges all files in the attributes folder anyway.

Sauraus · 2017-11-07T03:29:28Z

This PR should be broken up into 2 pieces:

Network Install
vs2017 addition

And a rebase -i HEAD~X would do wonder in terms of being able to grok the whole thing. :)

chaim1221 · 2018-03-05T06:21:07Z

Hello there, this has gone stale, any interest among the interested parties in reviving it? The AppVeyor build is currently broken, but I'll accept being able to manually confirm the results (myself, in a fresh environment) until I get #18 done.

Sauraus · 2018-03-05T16:34:35Z

I've gone ahead and made a fork here https://github.com/Roblox/visualstudio that does the vs2017 installs just fine for us.

ghost · 2018-03-05T17:29:47Z

Great, feel free to make a PR!

Sauraus · 2018-03-05T17:31:15Z

Ok I will squash all the commits for just vs2017 installation, I've left out the network installation which I didn't need and I also do not feel should be in the same PR anyway, give me a day or 2 to clean things up.

ghost · 2018-03-05T23:32:50Z

Cool. And no need to squash the commits if it's extra work. I just look at diffs.

Sauraus · 2018-03-05T23:36:34Z

Need to squash the commits to make sense of the changes myself. :D

ryangribble · 2018-03-07T00:43:09Z

i agree the network install should be done separately. i think it could possibly even deserve being a new resource as it is fairly different to the way the online installs are being done

laurencee · 2018-05-09T00:31:38Z

@Sauraus Heya, were you still creating a PR with just the VS2017 installation part?

Sauraus · 2018-05-09T01:08:18Z

Yes its on my 'ever' to-do list sorry. :( I will try to make some time in the next 2 weeks.

smitsdj · 2018-09-20T09:43:33Z

Gents, what is the status of this PR? I'm looking for VS2017 support.

chaim1221 · 2018-10-02T23:09:53Z

Sorry! I have had no time to focus on this repo; went from some very intense DevOps to some very intense unemployment, now getting back in the saddle. The build appears to be broken. I will look when I get a chance.

yamamoto52 · 2018-10-16T10:04:00Z

what status is of this changes ? will it be merged successfully into master ?

chaim1221 · 2018-10-18T08:58:05Z

I will check the PR this weekend! Sorry last time I checked I didn’t see anything ready to go, then I had to move.

On Tue, Oct 16, 2018 at 3:04 AM yamamoto52 ***@***.***> wrote: what status is of this changes ? will it be merged successfully into master ? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#11 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADpJwkoDmFks0mj_JEiOq5ZgdhB0eRSNks5ula8RgaJpZM4NOU1q> .

-- * • Chaim S. Eliyah •* (c) *+*1.206.331.1311 *This message may be privileged under the Electronic Communication Privacy Act,18 U.S.C.A. §§ 2510-2521. Delete this email if you have received it in error or are not its original intended recipient, and do not copy any part of it. Thank you.*

EasyAsABC123 · 2019-03-29T15:07:36Z

We are not in 2019...where is this support?

jonathanan · 2019-03-29T21:19:37Z

Haven't tried it but this cookbook looks promising:
https://supermarket.chef.io/cookbooks/vs-2017
https://github.com/btc-ag/chef-vs2017

Stromweld · 2024-05-03T21:07:24Z

closing this PR as old and outdated now.

taliesins and others added 23 commits April 25, 2017 14:19

If resource source is set to nil then assume that we are doing a netw…

169837f

…ork or local install. This means we don't want to extract or clean Visual Studio ISO.

Only throw an exception when src is nil if we have not specified an i…

508333f

…nstaller_file. The installer_file could be the path the full path to the network install

Chef windows_package uses returns instead of success_code

3ab9f46

Comparing values. Not setting them.

cd15ecd

If a value is nil or empty we should consider it to be overridden and…

8946cbf

… use the installer_exe path only

Use empty? rather

f01608a

source attribute is now optional

be9be71

replace empty with blank

959d08d

remove blank

acff8a4

Make it a function

291c331

Add Visual Studio 2017

d8fe130

Add ability to install via web installer

Better to use casecmp instead of downcase ==

623e5c7

Source is a required parameter, so only evaluate when we know its not…

a96ccea

… null

Use preferred ruby style for checking if nil

5e74354

Property does not exist (copied over from seven_zip extract)

0dcb25d

Use empty instead of blank

ac05ea9

Display whats going on for debug purposes

f0589bf

Takes a long time, lets see what the progress is

6905bdd

At the moment Visual Studio is waiting on user input if its run from …

e0c2a03

…commandline and its already installed. Perhaps passing in all the options will stop that.

Just enumerate attributes directly.

aaeb2d9

Added missing square bracket

a595002

Update documentation for Visual Studio 2017 and network installs

19bd9d7

taliesins mentioned this pull request May 2, 2017

Support VS 2017 #9

Open

Taliesin Sisson added 2 commits May 2, 2017 17:59

Rubocop suggestions

93ac50d

More rubocop suggestions

bd0ee84

sneal mentioned this pull request May 26, 2017

windows_package uses 'returns' not 'source_codes' #10

Merged

Taliesin Sisson and others added 5 commits August 11, 2017 15:44

These references are not used

e98dbd0

Handle empty string and nil strings

92e52a5

Fixed RuboCop errors.

155b178

Merge pull request #2 from bemehiser/NetworkInstall

0b3eb7c

Fixed RuboCop Errors

array literals should use round brackets

e9ac772

taliesins mentioned this pull request Oct 5, 2017

Support WebInstallers #16

Closed

Sauraus reviewed Nov 7, 2017

View reviewed changes

linusruth mentioned this pull request May 14, 2018

Make sure our info and versions are up to date on the Chef Supermarket #26

Closed

Stromweld closed this May 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Visual Studio 2017 and network installs #11

Visual Studio 2017 and network installs #11

taliesins commented May 2, 2017

steveruddell commented May 26, 2017

sneal commented May 26, 2017 •

edited

Loading

taliesins commented May 28, 2017

ryangribble commented Aug 21, 2017

spotlesscoder commented Oct 2, 2017

taliesins commented Oct 5, 2017

ryangribble commented Oct 5, 2017

Sauraus Nov 7, 2017

Sauraus commented Nov 7, 2017

chaim1221 commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ghost commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ghost commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ryangribble commented Mar 7, 2018

laurencee commented May 9, 2018

Sauraus commented May 9, 2018

smitsdj commented Sep 20, 2018

chaim1221 commented Oct 2, 2018

yamamoto52 commented Oct 16, 2018

chaim1221 commented Oct 18, 2018 via email

EasyAsABC123 commented Mar 29, 2019

jonathanan commented Mar 29, 2019

Stromweld commented May 3, 2024

Visual Studio 2017 and network installs #11

Visual Studio 2017 and network installs #11

Conversation

taliesins commented May 2, 2017

steveruddell commented May 26, 2017

sneal commented May 26, 2017 • edited Loading

taliesins commented May 28, 2017

ryangribble commented Aug 21, 2017

spotlesscoder commented Oct 2, 2017

taliesins commented Oct 5, 2017

ryangribble commented Oct 5, 2017

Sauraus Nov 7, 2017

Choose a reason for hiding this comment

Sauraus commented Nov 7, 2017

chaim1221 commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ghost commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ghost commented Mar 5, 2018

Sauraus commented Mar 5, 2018

ryangribble commented Mar 7, 2018

laurencee commented May 9, 2018

Sauraus commented May 9, 2018

smitsdj commented Sep 20, 2018

chaim1221 commented Oct 2, 2018

yamamoto52 commented Oct 16, 2018

chaim1221 commented Oct 18, 2018 via email

EasyAsABC123 commented Mar 29, 2019

jonathanan commented Mar 29, 2019

Stromweld commented May 3, 2024

sneal commented May 26, 2017 •

edited

Loading