Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin BayesicFitting to < 3.1.0 #7435

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Jan 18, 2023

This PR pins the BayesicFitting package to < 3.1.0, which was released on PyPi in the past couple hours, because it causes an import failure, due to an error in the package's __init__. dokester/BayesicFitting#20 has been filed. This is causing all PR CI's to fail.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 78.53% // Head: 78.52% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (2959c23) compared to base (f25d3ee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7435      +/-   ##
==========================================
- Coverage   78.53%   78.52%   -0.02%     
==========================================
  Files         455      455              
  Lines       39084    39148      +64     
==========================================
+ Hits        30695    30740      +45     
- Misses       8389     8408      +19     
Flag Coverage Δ *Carryforward flag
nightly 78.51% <ø> (ø) Carriedforward from f25d3ee
unit 51.41% <ø> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/scripts/minimum_deps.py 24.00% <0.00%> (-1.00%) ⬇️
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/model_blender/blendmeta.py 83.05% <0.00%> (-0.71%) ⬇️
jwst/scripts/collect_pipeline_cfgs.py 13.33% <0.00%> (-0.46%) ⬇️
jwst/ami/lg_model.py 62.03% <0.00%> (-0.34%) ⬇️
jwst/refpix/irs2_subtract_reference.py 83.97% <0.00%> (-0.30%) ⬇️
jwst/ami/utils.py 87.96% <0.00%> (-0.29%) ⬇️
jwst/ami/nrm_core.py 20.61% <0.00%> (-0.28%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
jwst/extract_1d/soss_extract/atoca_utils.py 69.64% <0.00%> (-0.26%) ⬇️
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 6110e91 into spacetelescope:master Jan 18, 2023
@hbushouse hbushouse deleted the pin_bayesicfitting branch January 18, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants