Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove upper pin on BayesicFitting #7529

Merged

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Apr 7, 2023

This PR unpins the upper pin on BayesicFitting from #7435 to test if the import errors have now been fixed

Checklist for maintainers

  • [N/A] added entry in CHANGES.rst within the relevant release section
  • [N/A] updated or added relevant tests
  • [N/A] updated relevant documentation
  • [N/A] added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • [N/A] Make sure the JIRA ticket is resolved properly

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9e3a2c4) 77.42% compared to head (8d6765c) 77.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7529   +/-   ##
=======================================
  Coverage   77.42%   77.42%           
=======================================
  Files         452      452           
  Lines       36241    36241           
=======================================
  Hits        28060    28060           
  Misses       8181     8181           
Flag Coverage Δ
nightly 77.43% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett zacharyburnett marked this pull request as ready for review April 7, 2023 19:06
@zacharyburnett zacharyburnett requested a review from a team as a code owner April 7, 2023 19:06
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All CI tests have passed, so I guess that means the latest version is now OK?

@zacharyburnett
Copy link
Collaborator Author

zacharyburnett commented Apr 10, 2023

@zacharyburnett zacharyburnett merged commit b588e8d into spacetelescope:master Apr 11, 2023
@zacharyburnett zacharyburnett deleted the unpin_bayesicfitting branch April 11, 2023 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants