Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration options for part data #29

Closed
cdwilson opened this issue Apr 2, 2021 · 4 comments · Fixed by #31
Closed

Configuration options for part data #29

cdwilson opened this issue Apr 2, 2021 · 4 comments · Fixed by #31
Labels
enhancement New feature or request

Comments

@cdwilson
Copy link
Contributor

cdwilson commented Apr 2, 2021

@eeintech just wanted to let you know about a couple minor changes I've hacked into my local copy of to Ki-nTree to tailor it for my own usage, and see if you'd be interested in a PR to make them into configuration options in the settings.

  1. For part description, I use the detailed_description from Digi-Key instead of product_description
  2. For keywords, I use the product_description instead of inventree_part['description']
  3. For datasheet, I use the product_url since this ends up being the URL on the SupplierPart page in InvenTree.

image

Also, once inventree/InvenTree#1417 gets merged in, I'd like to add the ability for Ki-nTree to push both the primary_datasheet into the ManufacturerPart and the product_url into the SupplierPart.

It would be ideal if the ManufacturerPart in InvenTree eventually supports separate URLs for the Manufacturer's product page vs. the datasheet so that we can have both links available on the MPN. For example, if we look at 497-11767-ND:

ManufacturerPart

SupplierPart

@eeintech
Copy link
Contributor

eeintech commented Apr 2, 2021

@cdwilson Looks like a good idea!

If you do send a PR for flexible Digi-Key configuration, I would put it under a new file in "config > digikey > digikey_config.yaml".
And make sure the default is what's in right now 😃

Once we complete the implementation of ManufacturerPart, I'll update the inventree-python API and Ki-nTree 👍

@cdwilson
Copy link
Contributor Author

cdwilson commented Apr 2, 2021

If you do send a PR for flexible Digi-Key configuration, I would put it under a new file in "config > digikey > digikey_config.yaml".
And make sure the default is what's in right now 😃

Yeah, I'll make sure to do that. I also realized that we probably want a similar yaml configuration file for some of the other user-configurable settings that exist in the settings.py file today (like the IPN changes I made in #26).

Once we complete the implementation of ManufacturerPart, I'll update the inventree-python API and Ki-nTree 👍

Great! I may wait on this PR until after you make these changes so I can add an option to push both the primary_datasheet and the product_url into the respective ManufacturerPart / SupplierPart.

@eeintech
Copy link
Contributor

eeintech commented Apr 7, 2021

Yeah, I'll make sure to do that. I also realized that we probably want a similar yaml configuration file for some of the other user-configurable settings that exist in the settings.py file today (like the IPN changes I made in #26).

For that I started PR #31. I will also add a bunch of general settings for controlling the software behavior.

@eeintech
Copy link
Contributor

eeintech commented Apr 7, 2021

@cdwilson I updated the PR to handle the three Digi-Key settings from your original request, try it out! 😃

@eeintech eeintech added the enhancement New feature or request label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants