-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration options for part data #29
Comments
@cdwilson Looks like a good idea! If you do send a PR for flexible Digi-Key configuration, I would put it under a new file in "config > digikey > digikey_config.yaml". Once we complete the implementation of ManufacturerPart, I'll update the inventree-python API and Ki-nTree 👍 |
Yeah, I'll make sure to do that. I also realized that we probably want a similar yaml configuration file for some of the other user-configurable settings that exist in the
Great! I may wait on this PR until after you make these changes so I can add an option to push both the |
For that I started PR #31. I will also add a bunch of general settings for controlling the software behavior. |
@cdwilson I updated the PR to handle the three Digi-Key settings from your original request, try it out! 😃 |
@eeintech just wanted to let you know about a couple minor changes I've hacked into my local copy of to Ki-nTree to tailor it for my own usage, and see if you'd be interested in a PR to make them into configuration options in the settings.
detailed_description
from Digi-Key instead ofproduct_description
product_description
instead ofinventree_part['description']
product_url
since this ends up being the URL on theSupplierPart
page in InvenTree.Also, once inventree/InvenTree#1417 gets merged in, I'd like to add the ability for Ki-nTree to push both the
primary_datasheet
into theManufacturerPart
and theproduct_url
into theSupplierPart
.It would be ideal if the
ManufacturerPart
in InvenTree eventually supports separate URLs for the Manufacturer's product page vs. the datasheet so that we can have both links available on the MPN. For example, if we look at 497-11767-ND:ManufacturerPart
primary_datasheet
): https://www.st.com/content/ccc/resource/technical/document/datasheet/ef/92/76/6d/bb/c2/4f/f7/DM00037051.pdf/files/DM00037051.pdf/jcr:content/translations/en.DM00037051.pdfSupplierPart
product_url
): https://www.digikey.com/product-detail/en/stmicroelectronics/STM32F405RGT6/497-11767-ND/2754208The text was updated successfully, but these errors were encountered: