New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration settings for IPNs #26

Merged

eeintech merged 1 commit into sparkmicro:master from cdwilson:cdwilson/configurable-ipns

Mar 23, 2021

Contributor

cdwilson commented Mar 22, 2021

@eeintech curious to get your thoughts on this.

Currently, Ki-nTree only supports "semi-intelligent" IPNs of the form {category_id}-{unique_id}-{variant_id}.

This PR does four things:

It makes the unique ID length configurable via settings.IPN_UNIQUE_ID_LENGTH
It makes the variant suffix ID configurable via settings.IPN_VARIANT_SUFFIX
It makes the variant suffix optional via settings.IPN_USE_VARIANT_SUFFIX
It adds the ability to use a "non-intelligent" IPN scheme with an optional fixed prefix via settings.IPN_USE_FIXED_PREFIX. If IPN_USE_FIXED_PREFIX == '' (default), no prefix is added to the IPN.

This allows IPNs like the following:

000123
123
PREFIX-00123
FOO-12345-A
000123-01


          Add configuration settings for IPNs

cfc51bd

Contributor

eeintech commented Mar 22, 2021

@cdwilson Looks like a great addition! I'm going to play with it later this week 😉

eeintech merged commit c92c7da into sparkmicro:master

cdwilson mentioned this pull request

Configuration options for part data #29

Closed

eeintech mentioned this pull request

0.3.6 - Improved Settings #31

Merged

cdwilson deleted the cdwilson/configurable-ipns branch

April 15, 2021 04:49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet