-
-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: migrate to webpack #1981
Conversation
so that it can work when respec processor ends before adding message event listener.
This is looking great! Thank you for doing all this. Really impressive work with I've a few doubts:
|
This still uses requirejs but only to keep using
|
as it's used in `tests/core/highlight.html`.
This reverts commit cfa7937.
Marked as breaking change, as the text loader will break downstream (that's ok tho 👍 ). It seems that once this is in place, it should be quite simple for downstream folks to fix their imports. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
#1985 does help 🎉 |
IMO mostly done, the last problem is that the highlighter is again randomly failing. 😱