Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: migrate to webpack #1981

Merged
merged 26 commits into from
Jan 1, 2019
Merged

BREAKING CHANGE: migrate to webpack #1981

merged 26 commits into from
Jan 1, 2019

Conversation

saschanaz
Copy link
Collaborator

IMO mostly done, the last problem is that the highlighter is again randomly failing. 😱

@sidvishnoi
Copy link
Member

This is looking great! Thank you for doing all this. Really impressive work with expose-modules!

I've a few doubts:

  1. We still have requireJS. Is this something we will remove in next PRs?
  2. Why are we importing styles as raw strings and not with style-loader? I was hoping we could minify the CSS in the production build.

@saschanaz
Copy link
Collaborator Author

saschanaz commented Dec 29, 2018

We still have requireJS. Is this something we will remove in next PRs?

This still uses requirejs but only to keep using examples/basic.html and some tests. I think @marcoscaceres preferred this non-optimized way when debugging because of sourcemap glitches on several browsers.

Why are we importing styles as raw strings and not with style-loader? I was hoping we could minify the CSS in the production build.

style-loader will block future migration to native ES modules and also break examples/basic.html. Maybe a topic for new PRs.

package.json Outdated Show resolved Hide resolved
@marcoscaceres marcoscaceres changed the title refactor: migrate to webpack BREAKING CHANGE: migrate to webpack Jan 1, 2019
@marcoscaceres
Copy link
Contributor

Marked as breaking change, as the text loader will break downstream (that's ok tho 👍 ). It seems that once this is in place, it should be quite simple for downstream folks to fix their imports.

Copy link
Contributor

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@saschanaz
Copy link
Collaborator Author

#1985 does help 🎉

@saschanaz saschanaz merged commit d5a62ba into develop Jan 1, 2019
@saschanaz saschanaz deleted the webpack branch January 1, 2019 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants