refactor(tests/spec/SpecHelper): avoid call() #1985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also fix the problem in #1981 where ReSpec is incorrectly loaded twice. Inserting ReSpec twice has not been a problem with requirejs as 1) previously ReSpec has been a set of AMD modules 2) defining an AMD module twice does not overwrite the previous one. With webpack ReSpec is not a set of modules anymore, so it becomes a problem. |
sidvishnoi
reviewed
Dec 31, 2018
|
Happy 2019! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as
call()makes code hard to read 🤔