-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an Add and Delete tree ranks option #4257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excited to finally have this coming to sp7!
just hoping there isn't some dark magic/special logic going on in sp6 that we may be missing here
77223ec
to
19bc954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
back-end endpoints are overcomplicated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
-
Open a tree
-
Click on the plus icon in the header, located between the pencil and the first rank (Planet | Earth | Root | ...)
-
Choose a parent rank
-
Click continue
-
Define the proprieties of your new rank
-
save
-
verify that the new node has been added into the tree ranks
-
Open a tree
-
Click on the pencil icon in the header, located at the front of the headers, before the first rank (Planet | Earth | Root | ...)
-
Click on a pencil next to a tree rank
-
Click delete
-
Confirm deletion
-
verify that the new node has been deleted from the tree ranks
Deletion Blocker looks great!
Uja5aN07nf.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing instructions
-
Open a tree
-
Click on the plus icon in the header, located between the pencil and the first rank (Planet | Earth | Root | ...)
-
Choose a parent rank
-
Click continue
-
Define the proprieties of your new rank
-
save
-
verify that the new node has been added into the tree ranks
-
Open a tree
-
Click on the pencil icon in the header, located at the front of the headers, before the first rank (Planet | Earth | Root | ...)
-
Click on a pencil next to a tree rank
-
Click delete
-
Confirm deletion
-
verify that the new node has been deleted from the tree ranks
Adding and deleting works as expected and the deletion blocker shows up, great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor changes, except the parent query. I don't personally think it is necessary (you can get the parent directly) so searching by name is redundant, Am i misunderstanding something?
Fixes #598
Checklist
and self-explanatory (or properly documented)
Testing instructions
Open a tree
Click on the plus icon in the header, located between the pencil and the first rank (Planet | Earth | Root | ...)
Choose a parent rank
Click continue
Define the proprieties of your new rank
save
verify that the new node has been added into the tree ranks
Open a tree
Click on the pencil icon in the header, located at the front of the headers, before the first rank (Planet | Earth | Root | ...)
Click on a pencil next to a tree rank
Click delete
Confirm deletion
verify that the new node has been deleted from the tree ranks