Correctly set isAccepted on Tree node save #5028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melton-jason
changed the title
CarolineDenis
approved these changes
Jun 21, 2024
emenslin
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Testing instructions
For any Tree Record (Geography, Taxon, Storage, Chronostratigraphy, and/or Lithostratigraphy):
- Save the record without setting a Preferred Node
- Ensure the
Is Preferred(isAcceptedfield) checkbox is checked (True) - Set a Preferred Node for the record and save
- Ensure the
Is Preferred(isAcceptedfield) checkbox is unchecked (False)
Looks good!
Areyes42
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
Testing instructions
For any Tree Record (Geography, Taxon, Storage, Chronostratigraphy, and/or Lithostratigraphy):
- Save the record without setting a Preferred Node
- Ensure the
Is Preferred(isAcceptedfield) checkbox is checked (True) - Set a Preferred Node for the record and save
- Ensure the
Is Preferred(isAcceptedfield) checkbox is unchecked (False)
Looks good, changes get properly updated!
|
While I have only made changes to the test files, can this be testing briefly again more merge? |
grantfitzsimmons
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Testing instructions
For any Tree Record (Geography, Taxon, Storage, Chronostratigraphy, and/or Lithostratigraphy):
- Save the record without setting a Preferred Node
- Ensure the
Is Preferred(isAcceptedfield) checkbox is checked (True) - Set a Preferred Node for the record and save
- Ensure the
Is Preferred(isAcceptedfield) checkbox is unchecked (False)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5027
Caused by #4257
Specifically, the business rule was disabled and the logic was put on the TreeDefItem class
savemethod when it should have either remained a business rule or have been put in the Tree classsavemethod.Checklist
and self-explanatory (or properly documented)
Testing instructions
For any Tree Record (Geography, Taxon, Storage, Chronostratigraphy, and/or Lithostratigraphy):
Is Preferred(isAcceptedfield) checkbox is checked (True)Is Preferred(isAcceptedfield) checkbox is unchecked (False)