Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch attachments once gallery icon is clicked #4284

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fetch attachments once gallery icon is clicked #4284

merged 2 commits into from
Dec 19, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4261

@CarolineDenis CarolineDenis added this to the 7.9.3 milestone Dec 13, 2023
maxpatiiuk
maxpatiiuk approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, cool that it's that simple!
my solution was going to be worse...

@CarolineDenis CarolineDenis marked this pull request as ready for review December 14, 2023 16:01
pashiav
pashiav approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected. Looks good!

emenslin
emenslin approved these changes Dec 18, 2023
View reviewed changes
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and works as expected.

@CarolineDenis CarolineDenis merged commit 012cf2f into production Dec 19, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4261 branch December 19, 2023 14:42
@melton-jason melton-jason mentioned this pull request Jan 17, 2024
Closed
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-3-release-announcement/1499/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emenslin emenslin emenslin approved these changes

@pashiav pashiav pashiav approved these changes

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@bronwyncombs bronwyncombs Awaiting requested review from bronwyncombs

@carlosmbe carlosmbe Awaiting requested review from carlosmbe

@acwhite211 acwhite211 Awaiting requested review from acwhite211

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.3
Development

Successfully merging this pull request may close these issues.

Infinite loop with uniqueness checking rule
5 participants
@CarolineDenis @specifysoftware @maxpatiiuk @pashiav @emenslin