Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the missing border for query select items in the report query dialog #5159

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

grantfitzsimmons
Copy link
Member

Fixes #5149

It should appear as they did in v7.9.5, before the change in 8c80571
The borders for query items should not be extra bold as it was #4287

Describe the bug
When opening a report and then clicking query the outlines for the fields are missing

To Reproduce
Steps to reproduce the behavior:

  1. Go to reports in the navigation bar
  2. Click on any report/label
  3. Select query
  4. See error

Expected behavior
They should have the backgrounds like they did in 7.9.5

Screenshots
edge:
Screenshot 2024-07-26 151809

7.9.5:
Screenshot 2024-07-26 152305

Testing Instructions:

  • Verify that query lines have appropriately sized borders in
    • Query Builder in light mode
    • Query Builder in dark mode
    • Report/Label Query Dialogs in light mode
    • Report/Label Query Dialogs in dark mode

@grantfitzsimmons grantfitzsimmons requested review from a team July 30, 2024 01:20
@grantfitzsimmons grantfitzsimmons added this to the 7.9.7 milestone Jul 30, 2024
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Verify that query lines have appropriately sized borders in

    • Query Builder in light mode
    • Query Builder in dark mode
    • Report/Label Query Dialogs in light mode
    • Report/Label Query Dialogs in dark mode

    Works! The borders appear as they should and Queries and Reports match up 👍👍👍

@alesan99 alesan99 requested a review from a team July 30, 2024 14:19
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing Instructions:

  • Verify that query lines have appropriately sized borders in
    • Query Builder in light mode
    • Query Builder in dark mode
    • Report/Label Query Dialogs in light mode
    • Report/Label Query Dialogs in dark mode

Borders look good 🎉

@grantfitzsimmons grantfitzsimmons merged commit 526a059 into production Jul 30, 2024
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-5149 branch July 30, 2024 14:34
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

${handleClick === undefined ? '' : 'border border-gray-500'}

One small comment here, can this line be removed?
Pretty sure it is redundant now, as the component always has the border border-gray-500 class.

@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

In light mode field outline is missing in report query
7 participants