-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore the missing border for query select items in the report query dialog #5159
Conversation
Reimplement timestamp logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Verify that query lines have appropriately sized borders in
- Query Builder in light mode
- Query Builder in dark mode
- Report/Label Query Dialogs in light mode
- Report/Label Query Dialogs in dark mode
Works! The borders appear as they should and Queries and Reports match up 👍👍👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing Instructions:
- Verify that query lines have appropriately sized borders in
- Query Builder in light mode
- Query Builder in dark mode
- Report/Label Query Dialogs in light mode
- Report/Label Query Dialogs in dark mode
Borders look good 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
specify7/specifyweb/frontend/js_src/lib/components/WbPlanView/CustomSelectElement.tsx
Line 591 in 526a059
${handleClick === undefined ? '' : 'border border-gray-500'} |
One small comment here, can this line be removed?
Pretty sure it is redundant now, as the component always has the border border-gray-500
class.
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-7-release-announcement/1979/1 |
Fixes #5149
It should appear as they did in
v7.9.5
, before the change in 8c80571The borders for query items should not be extra bold as it was #4287
Testing Instructions: