Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable select button when no row selected in QB #5270

Open
wants to merge 1 commit into
base: production
Choose a base branch
from

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Sep 11, 2024

Fixes #5259

Checklist

  • Self-review the PR after opening it to make sure the changes look good
    and self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Go to Data Entry and create a new CO record
Click the Search button on a query combo box
Click Query Builder and query for a record
Click on a record
Click Deselect All and see that it appears to have been deselected

  • verify select is disabled

@CarolineDenis CarolineDenis requested a review from a team September 12, 2024 13:08
@CarolineDenis CarolineDenis added this to the 7.9.8 milestone Sep 12, 2024
@CarolineDenis CarolineDenis marked this pull request as ready for review September 12, 2024 13:08
Copy link
Contributor

@alesan99 alesan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Go to Data Entry and create a new CO record
Click the Search button on a query combo box
Click Query Builder and query for a record
Click on a record
Click Deselect All and see that it appears to have been deselected

  • verify select is disabled

Looks good! 👍👍

@alesan99 alesan99 requested a review from a team September 12, 2024 13:16
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

Go to Data Entry and create a new CO record
Click the Search button on a query combo box
Click Query Builder and query for a record
Click on a record
Click Deselect All and see that it appears to have been deselected

  • verify select is disabled

Looks good, select is disabled

chrome_nxefojCMU3.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋Back Log
Development

Successfully merging this pull request may close these issues.

Query Builder Deselect All button from Search dialog behaves incorrectly
5 participants