Skip to content

Commit

Permalink
Preserve graph options when clicking d3 nodes (#2139)
Browse files Browse the repository at this point in the history
When clicking a d3 node, the new url was built up with a static set of
options, clearing out things like hide done and invert. This means the
graph would flip or gain lots of nodes when you click a link. In order
to better preserve the options, we now simply change the taskId in the
current URL.
  • Loading branch information
daveFNbuck authored and Tarrasch committed May 31, 2017
1 parent 20bd7b0 commit d5c193b
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion luigi/static/visualiser/js/visualiserApp.js
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,8 @@ function visualiserApp(luigi) {
});
}
else {
window.location.href = 'index.html#tab=graph&visType=d3&taskId=' + taskId;
fragmentQuery['taskId'] = taskId;
window.location.href = 'index.html#' + URI.buildQuery(fragmentQuery);
}
});
}
Expand Down

0 comments on commit d5c193b

Please sign in to comment.