Preserve graph options when clicking d3 nodes #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When clicking a d3 node, the new url was built up with a static set of options, clearing out things like hide done and invert. This means the graph would flip or gain lots of nodes when you click a link. In order to better preserve the options, we now simply change the taskId in the current URL.
|
@daveFNbuck, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nmb10, @riga and @patricksmith to be potential reviewers. |
|
Great! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just replace the taskId in the current url when clicking a d3 node rather than building a whole new options hash.
Motivation and Context
When clicking a d3 node, the new url was built up with a static set of options, clearing out things like hide done and invert. This means the graph would flip or gain lots of nodes when you click a link. In order to better preserve the options, we now simply change the taskId rather than building the full link.
Have you tested this? If so, how?
Ran locally and tried clicking links in a d3 graph to make sure things work as expected.