Remove sitecustomize file #1755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tarrasch
force-pushed
the
remove-sitecustomize-file
branch
from
17d89fc
to
006dc2b
Compare
Current coverage is 75.93%@@ master #1755 diff @@
==========================================
Files 95 90 -5
Lines 10348 9892 -456
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8155 7511 -644
- Misses 2193 2381 +188
Partials 0 0
|
|
@gpoulin, is this kinda what you said in #1693 (comment)? Can you do a quick review? |
See discussion in spotify#1693 Luigi developrs might need to run `rm .coverage` after applying this change as a new version of coverage will be in use after this patch.
Tarrasch
force-pushed
the
remove-sitecustomize-file
branch
from
006dc2b
to
5bb1dab
Compare
|
Die you incomprehensible root folder file! >_< |
p7k
pushed a commit
to Celmatix/luigi
that referenced
this pull request
Jul 28, 2016
* spotify/master: (24 commits) Add DateSecondParameter to parameter.py (spotify#1779) tox: Specify sphinx dependency better flake8: Unbreak travis build Excludes .tox from flake8 to prevent checking third-party libraries (spotify#1785) README: Remove monthly downloads badge Rename CentralPlannerScheduler to Scheduler (spotify#1781) Remove abstract Scheduler class (spotify#1778) Assistants: Don't affect longevity of tasks (spotify#1772) tests: Skip a inttermittently failing s3 test (spotify#1777) Update retcodes to handle new cases (spotify#1771) tests: Fix warning in remote_scheduler_test.py (spotify#1774) Remove sitecustomize file (spotify#1755) Fix exist method for ftp server Update copy() to return number and size of files copied Remove the confusing "dummy_test_module" directory (spotify#1756) Disable codecov comments on GitHub PRs (spotify#1754) Fix "owner_email" log message. (spotify#1762) docs: Install sphinx 1.4.4 in setup.py (spotify#1761) docs: Set minimum versions for sphinx (spotify#1760) Normalize ListParameter to be Immutable (spotify#1759) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Less files, less confusion. This came to be from discussion in #1693
Have you tested this? If so, how?
Not tested. I entirely rely on Travis for this. In particular there could be flags misspelled and other unknown incompatibilities as of the new version of coverage.
Luigi developers might need to run
rm .coverageafter applying this change as a new version of coverage will be in use after this patch.