docs: Set minimum versions for sphinx #1760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I saw that the build was failing, hence this is my attempt to fix it, altough I don't know how to test this before merging it. See https://readthedocs.org/projects/luigi/builds/4189801/ Unfortunately I couldn't find a way to connect a webhook between GitHub PRs and readthedocs: readthedocs/readthedocs.org#1340 The reason I believe a version bump would fix it is because I see exactly the same error as in sphinx-doc/sphinx#2465 and readthedocs seem to use 1.3.5, causing the pdf docs to be outdated.
|
@Tarrasch, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jcrobak, @themalkolm and @steenzout to be potential reviewers |
Current coverage is 76.13%@@ master #1760 diff @@
==========================================
Files 95 95
Lines 10350 10350
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 8155 7880 -275
- Misses 2195 2470 +275
Partials 0 0
|
|
This patch wasn't enough, but it got fixed in #1761! |
p7k
pushed a commit
to Celmatix/luigi
that referenced
this pull request
Jul 28, 2016
* spotify/master: (24 commits) Add DateSecondParameter to parameter.py (spotify#1779) tox: Specify sphinx dependency better flake8: Unbreak travis build Excludes .tox from flake8 to prevent checking third-party libraries (spotify#1785) README: Remove monthly downloads badge Rename CentralPlannerScheduler to Scheduler (spotify#1781) Remove abstract Scheduler class (spotify#1778) Assistants: Don't affect longevity of tasks (spotify#1772) tests: Skip a inttermittently failing s3 test (spotify#1777) Update retcodes to handle new cases (spotify#1771) tests: Fix warning in remote_scheduler_test.py (spotify#1774) Remove sitecustomize file (spotify#1755) Fix exist method for ftp server Update copy() to return number and size of files copied Remove the confusing "dummy_test_module" directory (spotify#1756) Disable codecov comments on GitHub PRs (spotify#1754) Fix "owner_email" log message. (spotify#1762) docs: Install sphinx 1.4.4 in setup.py (spotify#1761) docs: Set minimum versions for sphinx (spotify#1760) Normalize ListParameter to be Immutable (spotify#1759) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that the readthedocs build was failing, hence this is my attempt to fix it,
altough I don't know how to test this before merging it.
See https://readthedocs.org/projects/luigi/builds/4189801/
Unfortunately I couldn't find a way to connect a webhook between GitHub
PRs and readthedocs: readthedocs/readthedocs.org#1340
The reason I believe a version bump would fix it is because I see
exactly the same error as in sphinx-doc/sphinx#2465 and readthedocs
seem to use 1.3.5, causing the pdf docs to be outdated.