Moves error messages in the task list to a popup #1827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When error messages with long lines appear in the task list data table, they can stretch the table width beyond that of the window. Horizontal scrolling is impossible, hiding both the error message and the action buttons needed for hiding the error message or showing others. As the error message popup works well in the graph, this is easily solved by just using the same popup for displaying error messages in the task list. This popup has a fixed size and allows horizontal scrolling when lines exceed it.
|
@daveFNbuck, thanks for your PR! By analyzing the annotation information on this pull request, we identified @riga, @harpaj and @patricksmith to be potential reviewers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Displays error messages in the task list using a popup like in the graph view rather than inline in the table rows.
Motivation and Context
When error messages with long lines appear in the task list data table, they can stretch the table width beyond that of the window. Horizontal scrolling is impossible, hiding both the error message and the action buttons needed for hiding the error message or showing others.
As the error message popup works well in the graph, this is easily solved by just using the same popup for displaying error messages in the task list. This popup has a fixed size and allows horizontal scrolling when lines exceed it.
Have you tested this? If so, how?
I'm using it in production now. It works much better than before.
Before:
After:
