Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves error messages in the task list to a popup #1827

Merged
merged 1 commit into from
Aug 26, 2016
Merged

Moves error messages in the task list to a popup #1827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions luigi/static/visualiser/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,16 +231,6 @@
{{#statusMessage}}<button class="btn btn-primary btn-xs statusMessage" title="Status message" data-toggle="tooltip" data-task-id="{{taskId}}" data-display-name={{displayName}}><i class="fa fa-comment"></i></button>{{/statusMessage}}
</div>
</script>
<script type="text/template" name="rowDetailsTemplate">
<table cellpadding="5" cellspacing="0" border="0" style="padding-left:50px;">
{{#error}}
<tr>
<td>Exception:</td>
<td class="error-trace"></td>
</tr>
{{ /error }}
</table>
</script>
<script type="text/template" name="errorTemplate">
<div class="modal-dialog">
<div class="modal-content">
Expand Down
23 changes: 3 additions & 20 deletions luigi/static/visualiser/js/visualiserApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,26 +911,9 @@ function visualiserApp(luigi) {
var tr = $(this).closest('tr');
var row = dt.row( tr );
var data = row.data();

if ( row.child.isShown() ) {
// This row is already open - close it
row.child.hide();
}
else {
// Open this row
row.child(Mustache.render(templates['rowDetailsTemplate'], data)).show();

// If error state is present retrieve the error
if (data.error) {
errorTrace = row.child().find('.error-trace');
luigi.getErrorTrace(data.taskId, function(error) {
errorTrace.html('<pre class="pre-scrollable">'+decodeError(error.error)+'</pre>');
});
}


}

luigi.getErrorTrace(data.taskId, function(error) {
showErrorTrace(error);
});
} );

$('#taskTable tbody').on('click', 'td.details-control .re-enable-button', function () {
Expand Down