Prevents batch tasks from running before their dependencies #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding tasks to an existing batch in get_work, we neglected to check whether the tasks were schedulable. This meant that in production I found my pipelines running batches that included jobs with PENDING dependencies. In order to fix this, we simply add a check that the task is schedulable. Note that even though self._schedulable(task) gets called twice in the get_work loop, they fall under different branches of whether best_task is defined, so this shouldn't slow get_work down much.
|
Thanks. Am I correct in that this is a pretty serious bug as it would run a task before it's dependencies are complete? |
|
Yes, that was what happened in production after I deployed a version of Luigi with this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checks whether batch tasks are schedulable before adding them to a batch in get_work.
Note that even though self._schedulable(task) gets called twice in the get_work loop, they fall under different branches of whether best_task is defined, so this shouldn't slow get_work down much.
Motivation and Context
When adding tasks to an existing batch in get_work, we neglected to check whether the tasks were schedulable. This meant that in production I found my pipelines running batches that included jobs with PENDING dependencies. In order to fix this, we simply add a check that the task is schedulable.
Have you tested this? If so, how?
I have included unit tests.