Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevents batch tasks from running before their dependencies #1846

Merged
merged 1 commit into from
Sep 12, 2016
Merged

Prevents batch tasks from running before their dependencies #1846

merged 1 commit into from
Sep 12, 2016

Commits on Sep 8, 2016

  1. Prevents batch tasks from running before their dependencies 

    When adding tasks to an existing batch in get_work, we neglected to check
whether the tasks were schedulable. This meant that in production I found
my pipelines running batches that included jobs with PENDING dependencies.
In order to fix this, we simply add a check that the task is schedulable.

Note that even though self._schedulable(task) gets called twice in the
get_work loop, they fall under different branches of whether best_task is
defined, so this shouldn't slow get_work down much.
    @daveFNbuck
    daveFNbuck committed Sep 8, 2016
    Configuration menu
    Copy the full SHA
    02d8716 View commit details
    Browse the repository at this point in the history