Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for client to send ping messages for subscriptions #605

Closed
toby200 opened this issue Feb 5, 2023 · 3 comments
Closed

Support for client to send ping messages for subscriptions #605

toby200 opened this issue Feb 5, 2023 · 3 comments
Labels
status: superseded Issue is superseded by another

Comments

@toby200
Copy link
Contributor

toby200 commented Feb 5, 2023

Whilst the client now supports responding to ping messages from the server with a pong, there's no mechanism for WebSocketGraphQlClient to send a regular ping to the server itself. As per the graphql-ws spec these are bi-directional messages so should be supported either way around.

The apollo graphql client supports similar functionality via the "keepalive" option from the graphql-ws ClientOptions - perhaps a similar approach would work well here as well?
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 5, 2023
toby200 added a commit to toby200/spring-graphql that referenced this issue Feb 8, 2023
@toby200
spring-projects#605 Support for client to send ping messages for subs…
8b301a5 
…criptions
toby200 added a commit to toby200/spring-graphql that referenced this issue Feb 8, 2023
@toby200
spring-projects#605 Support for client to send ping messages for subs…
ae19f43 
…criptions
toby200 added a commit to toby200/spring-graphql that referenced this issue Feb 8, 2023
@toby200
spring-projects#605 Support for client to send ping messages for subs…
8ead7b6 
…criptions
@toby200
Copy link
Contributor Author

toby200 commented Feb 8, 2023

I've raised a pull request to address this
#608

toby200 added a commit to toby200/spring-graphql that referenced this issue Feb 8, 2023
@toby200
spring-projects#605 Support for client to send ping messages for subs…
6ab298b 
…criptions
@rstoyanchev rstoyanchev linked a pull request Feb 9, 2023 that will close this issue
Support keep-alive pings in WebSocketGraphQlClient #608
Closed
@rstoyanchev
Copy link
Contributor

Thanks, I'll close this as superseded by the PR. We can continue the conversation there.

@rstoyanchev rstoyanchev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
@rstoyanchev rstoyanchev added status: superseded Issue is superseded by another and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 9, 2023
@rinkumandi
Copy link

@rstoyanchev May I know the maven dependency that has this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: superseded Issue is superseded by another
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support keep-alive pings in WebSocketGraphQlClient toby200/spring-graphql
4 participants
@rstoyanchev @rinkumandi @toby200 @spring-projects-issues