Support keep-alive pings in WebSocketGraphQlClient #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
|
We have a similar requirement for server-side pings in #534. |
|
+1 for this feature. Client should be able to send a ping message to server to keep the channel open. |
rstoyanchev
changed the title
rstoyanchev
pushed a commit
that referenced
this pull request
Apr 11, 2024
rstoyanchev
added a commit
that referenced
this pull request
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a keepalive option to the WebSocketGraphQlClient builder. This gets passed down to the WebSocketGraphQlTransport which then sends graphql ping messages over the websocket every keepalive seconds.
I've added basic handling to accept the pong messages back, but no processing or checks that a pong response is received in a timely manner, similar to the graphql-ws client library.