Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply a setter for the logger field of RetryTemplate so that it doesn't need to be injected via reflections #470

Closed
klopfdreh opened this issue Sep 16, 2024 · 0 comments · Fixed by #471
Closed

Apply a setter for the logger field of RetryTemplate so that it doesn't need to be injected via reflections #470

klopfdreh opened this issue Sep 16, 2024 · 0 comments · Fixed by #471
Labels
enhancement
Milestone
2.0.10

Comments

@klopfdreh
Copy link
Contributor

klopfdreh commented Sep 16, 2024 •
edited
Loading

Currently there is a workaround in Spring Cloud Config (spring-cloud/spring-cloud-config#2456) that sets the logger of RetryTemplate via reflections. There should be a setter for the logger.

By fixing this issue the setter is applied to the RetryTemplate.
@klopfdreh klopfdreh mentioned this issue Sep 16, 2024
Merged
@ryanjbaxter ryanjbaxter mentioned this issue Sep 16, 2024
Merged
@klopfdreh klopfdreh changed the title Enable RetryTemplate for reflections to be used at Spring Boot Native images (aot) Apply a setter for the logger field of RetryTemplate so that it doesn't need to be injected via reflections Sep 19, 2024
@artembilan artembilan added this to the 2.0.10 milestone Sep 19, 2024
artembilan pushed a commit that referenced this issue Sep 19, 2024
@klopfdreh
feat: setter for Log of RetryTemplate (#471)
4886b75 
GH-470: Add `RetryTemplate.setLogger()` to avoid reflection in other places

Fixes: #470
Issue link: #470

Spring Cloud Config does mutation in the `RetryTemplate` for its system loading logger via `RetryTemplateFactory`.

* Expose setter for `logger` property to avoid reflection.
* Add `RetryTemplateBuilder.withLogger()` for convenience
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.0.10
Development

Successfully merging a pull request may close this issue.

feat: setter for logger field of RetryTemplate klopfdreh/spring-retry
2 participants
@klopfdreh @artembilan