feat: setter for logger field of RetryTemplate #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klopfdreh
force-pushed
the
fix/retrytemplateaot
branch
2 times, most recently
from
12cad57
to
8605e19
Compare
artembilan
requested changes
Sep 18, 2024
There was a problem hiding this comment.
As we discussion in the Spring Cloud issue , it would be better to avoid reflection altogether.
So, please, consider to rework your contribution into a setter for such a log instead.
Thanks
|
Hey - sure 👍 - I am going to change it, tomorrow. |
klopfdreh
force-pushed
the
fix/retrytemplateaot
branch
2 times, most recently
from
b641ef7
to
982eafc
Compare
klopfdreh
changed the title
artembilan
requested changes
Sep 19, 2024
src/main/java/org/springframework/retry/support/RetryTemplateBuilder.java
Show resolved
Hide resolved
klopfdreh
force-pushed
the
fix/retrytemplateaot
branch
from
982eafc
to
86fde69
Compare
|
thank you for contribution; looking forward for more! Now it is time to raise an issue in Spring Cloud Config to use this new setter instead of reflection. |
|
I already prepared the changes and I am going to create the PR and the issue, tomorrow. Edit: I had some time left and created the Issue (spring-cloud/spring-cloud-config#2544) and PR (spring-cloud/spring-cloud-config#2545): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #470
Because there is no Auto-Configuration I think it is fine to just add the hint without restrictions or class checks.