Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated targetSDK to 34 #114

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Updated targetSDK to 34 #114

wants to merge 24 commits into from

Conversation

Nilay-squareup
Copy link
Collaborator

@Nilay-squareup Nilay-squareup commented Aug 14, 2024

1. changed targetSdk to 34
2. changed graddle plugin to 8.7 and other dependencies to make the example app run on android
3. updated the dependencies permission_handler, barcode_scan2, firebase_core to make it compatible with SDK 34

4. updated platform :ios to 13.1 in Podfile to run the example of iOS
First three changes has been extracted into a separate PR #117 for android-only changes to support SDK 34.
This PR is now only about the iOS changes

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

@Armaxis Armaxis force-pushed the bump_targetSdk_to_34 branch 2 times, most recently from 2ca29e4 to 851c6a9 Compare August 27, 2024 21:16
@Armaxis
Copy link
Member

Armaxis commented Aug 27, 2024

Looks like we need to update/upload the provisioning profiles so the github actions can access them. allowProvisioningUpdates doesn't work, because it's in Github pipeline, I think

updated run script
fixing pipelines for ios
fixing pipeling for minifyEnable
fixing lint error for camera permission in pipelines
fixing notification permissions issue in pipelines
fixing proguard issue in pipeline
Copy link
Member

@brandonjenniges brandonjenniges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think you just need to update the Changelog with the changes to 4.0.2

CHANGELOG.md Show resolved Hide resolved
@@ -1,5 +1,9 @@
## Changelog

### v4.0.2 Sep 18, 2024

* Upgrade to Reader SDK 1.7.7 on Android.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this version also update to 1.7.4 on iOS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants