[feat]: give AnyWorkflow a Workflow conformance #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bencochran probably something you have opinions on |
…ow-workflow-conformance * origin/main: Expose AnyScreen.wrappedScreen for inspection (#193) Improve introspection for SignalProducerWorkflow actions (#192) [release]: bump version to 2.2.0 & remove separate concurrency version (#191) [feat]: add runtime observation API (#168) [chore]: refactor some internal actions to use existential any (#190) [fix]: use weak reference to internal sinks when vending to clients (#189) [feat]: add primary associated types to more protocols (#188) [chore]: pre major version bump cleanup (#187) [chore]: bump minimum deployment & swift versions (#186) Abstract ViewEnvironment to shared framework (#185)
jamieQ
commented
Feb 28, 2023
| renderingTransform: { $0 }, | ||
| outputTransform: { $0 } | ||
| )) | ||
| if let workflow = workflow as? AnyWorkflow<Rendering, Output> { |
There was a problem hiding this comment.
is there a way to get the compiler to do this without having to perform the runtime check?
jamieQ
commented
Feb 28, 2023
| /// Wrapper around an AnyWorkflow that allows us to have a concrete | ||
| /// WorkflowHost without WorkflowHostingController itself being generic | ||
| /// around a Workflow. | ||
| fileprivate struct RootWorkflow<Rendering, Output>: Workflow { |
jamieQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
the fact that
AnyWorkflowis not itself aWorkflowcreates confusion, and some awkwardness in some of our testing facilities. we'd like to add such a conformance to address these issues, and prevent consumers from having to write such type-erasing wrappers themselves.Changes
Workflowconformance toAnyWorkflowRootWorkflowwithAnyWorkflowinWorkflowHostingControllerChecklist
- [ ] UI Testsn/a- [ ] Snapshot Tests (iOS only)n/a- [ ] I have made corresponding changes to the documentationn/a