Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM WIP] SwiftUI testbed app #240

Closed
wants to merge 28 commits into from
Closed

[DNM WIP] SwiftUI testbed app #240

wants to merge 28 commits into from

Conversation

square-tomb
Copy link
Contributor

@square-tomb square-tomb commented Aug 16, 2023

A sample app designed for trying out approaches to porting Blueprint screens in a Workflow-driven app to SwiftUI.

I had found rewriting parts of the TicTacToe sample app to be of limited value due to the app’s simplicity and differences from Square's actual product code.

This should not be merged as it depends on Square internal libraries.

How to use

In the top-level directory, run

bundle install
be pod gen --verbose

The --verbose here is to make pod gen's progress visible, because it may take several minutes to download Market pods. Then

open gen/Development/Development.xcworkspace

With the project open in Xcode, select the target Development-SwiftUITestbed to build and run.

Links

Copy link
Collaborator

@n8chur n8chur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a great start for a test bed in which we can add new scenarios to test as we come up with them!
I'll try to take another more thorough pass before our call and try to come up with additional scenarios.

@n8chur
Copy link
Collaborator

n8chur commented Aug 28, 2023

It might also be nice to have a ProxyElement defined that creates a reusable component with an associated stylesheet involved here since that's a relatively common pattern that we'll want to also migrate. I don't think it's necessary from a Workflow standpoint, but if we're trying to test out what a conversion looks like it'd be nice to include!
I can help abstract a shared component if you'd like, but you can find info on how to do so yourself here: https://www.notion.so/marketdesignsystem/Making-Custom-Components-74370084ed354456860cb307c76a7bc5

square-tomb and others added 3 commits September 27, 2023 17:10
invert modal and Market containers

Co-authored-by: Westin Newell <[email protected]>
Co-authored-by: Westin Newell <[email protected]>
@square-tomb
Copy link
Contributor Author

It might also be nice to have a ProxyElement defined that creates a reusable component with an associated stylesheet involved here since that's a relatively common pattern that we'll want to also migrate… I can help abstract a shared component if you'd like…

@n8chur Per our conversation today, I'll take you up on adding/extracting that component! Feel free to push commits directly to this branch. I'll avoid rebasing from here on out.

@n8chur
Copy link
Collaborator

n8chur commented Sep 28, 2023

It might also be nice to have a ProxyElement defined that creates a reusable component with an associated stylesheet involved here since that's a relatively common pattern that we'll want to also migrate… I can help abstract a shared component if you'd like…

@n8chur Per our conversation today, I'll take you up on adding/extracting that component! Feel free to push commits directly to this branch. I'll avoid rebasing from here on out.

Done!

…ftui-testbed

* 'main' of github.com:square/workflow-swift:
  Add WorkflowSwiftUIExperimental  (#252)
  Add convenience method for library definitions to reduce boilerplate (#251)
  [release]: bump to version 3.4.0 (#250)
  RxSwift 6.6 (#212)
  Expose 'screen' on WorkflowHostingController (#246)
  [fix]: address some RenderTester limitations with optionals (#245)
  Resolved Swift 5.9 compilation warning related to UnsafeRawPointer object conversion (#243)
  Bump activesupport from 6.1.7.3 to 6.1.7.6 (#242)
@square-tomb square-tomb requested review from a team and removed request for a team December 19, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants