Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Sync GitHub Actions config with master as of commit 240efcb #1922

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Oct 26, 2024

Test staged commits using our docker images from Jenkins tests.
The added tests (see slow.yaml) were easier to adopt; we are also
working on enabling GitHub Actions for FreeBSD and some other images.

We do not run these added tests for PR commits because existing Ubuntu
tests (defined in quick.yaml) already expose the vast majority of build
problems, and we are worried that running a lot more tests for each PR
push event would consume too much GitHub resources and significantly
increase noise in PR checks summary, obscuring often-easier-to-handle
failures detected by quick.yaml tests.

CI: Sync GitHub Actions config with master as of commit 240efcb


Backported all v7 GitHub Actions changes as of master commit 240efcb,
except those related to master-specific CodeQL and MacOS tests.

@squid-anubis squid-anubis added M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-other https://github.com/measurement-factory/anubis#pull-request-labels labels Oct 27, 2024
@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Oct 29, 2024
@kinkie kinkie added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Oct 31, 2024
@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Oct 31, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Oct 31, 2024

@kinkie
Copy link
Contributor Author

kinkie commented Oct 31, 2024

Looks good, thanks for the help with the wording @rousskov . As the test run completes without error, I'll merge and focus on freebsd, ccache, other architectures, and finally decommissioning jenkins

@rousskov
Copy link
Contributor

rousskov commented Nov 1, 2024

thanks for the help with the wording

FWIW, my suggestion contained the entire commit message (i.e. PR title and the entire PR description). The current PR title and description (except for the footer) are, IMO, still misleading.

@kinkie
Copy link
Contributor Author

kinkie commented Nov 1, 2024

thanks for the help with the wording

FWIW, my suggestion contained the entire commit message (i.e. PR title and the entire PR description). The current PR title and description (except for the footer) are, IMO, still misleading.

Got you. Tweaked the wording some more with your input. I'm happy to land it now.

@kinkie kinkie merged commit 2f75bb1 into squid-cache:v6 Nov 1, 2024
8 of 9 checks passed
@kinkie kinkie deleted the v6-github-actions branch November 1, 2024 14:50
@rousskov
Copy link
Contributor

rousskov commented Nov 1, 2024

Got you. Tweaked the wording some more with your input.

Sigh. PR description got arguably worse. PR title has not changed at all.

@rousskov rousskov removed the S-waiting-for-author author action is expected (and usually required) label Nov 1, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Nov 1, 2024

ooh, that was the title you suggested using? It wasn't clear to me. I can amend it

kinkie added a commit that referenced this pull request Nov 1, 2024
Test staged commits using our docker images from Jenkins tests.
The added tests (see slow.yaml) were easier to adopt; we are also
working on enabling GitHub Actions for FreeBSD and some other images.

We do not run these added tests for PR commits because existing Ubuntu
tests (defined in quick.yaml) already expose the vast majority of build
problems, and we are worried that running a lot more tests for each PR
push event would consume too much GitHub resources and significantly
increase noise in PR checks summary, obscuring often-easier-to-handle
failures detected by quick.yaml tests.

----
Backported all v7 GitHub Actions changes as of master commit 240efcb,
except those related to master-specific CodeQL and MacOS tests.
@kinkie kinkie changed the title Use GitHub Actions for more OS-specific build tests CI: Sync GitHub Actions config with master as of commit 240efcb Nov 1, 2024
@squid-anubis squid-anubis added the M-merged https://github.com/measurement-factory/anubis#pull-request-labels label Nov 1, 2024
@rousskov
Copy link
Contributor

rousskov commented Nov 1, 2024

Alex: my suggestion contained the entire commit message (i.e. PR title and the entire PR description). The current PR title and description (except for the footer) are, IMO, still misleading.

Francesco: ooh, that was the title you suggested using? It wasn't clear to me.

Yes, when I say "title", I mean "title". When I say "entire commit message", I mean that too!

I can amend it

Please do not. It is not possible to amend a commit without force pushing. Please do not force-push official branches except in truly exceptional catastrophic events! This is not one of them.

You can amend PR title/description, of course, but the whole discussion is about commit message (that has been already formed based on then-current PR title/description). There is no need to amend PR title/description now IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants