Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Replace Fedora 39 with 41 #1926

Closed
wants to merge 1 commit into from
Closed

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Oct 30, 2024

Fedora 39 will become EOL on 2024-11-12. Fedora 41 has been released.

@kinkie
Copy link
Contributor Author

kinkie commented Oct 30, 2024

Workflow test run: https://github.com/kinkie/squid/actions/runs/11592207068

This will need to be backported to v6 after PR #1922 lands there

@squid-anubis squid-anubis added M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels and removed M-failed-description https://github.com/measurement-factory/anubis#pull-request-labels labels Oct 30, 2024
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing a link to staging test results! BTW, I suggest adding something like cat /etc/issue and/or uname -a to the beginning of Linux docker-based workflows to make it easier to validate that the right image was used. Right now, one would have to trust that the docker image was named correctly or fish for that virtualized OS information deep down in build logs (assuming it can be found at all). This suggestion/request is outside this PR scope, of course.

In PR description, I fixed formatting, removed a statement that duplicated PR title, and provided a specific EOL date from Fedora 39 schedule.

This will need to be backported to v6

Your call. To me, it feels like v6 (that will be itself EOL soon) should be tested against its contemporary environment (to the extend that is feasible, of course), even if that environment becomes obsolete from current time point of view.

@kinkie
Copy link
Contributor Author

kinkie commented Oct 30, 2024

Thank you for providing a link to staging test results! BTW, I suggest adding something like cat /etc/issue and/or uname -a to the beginning of Linux docker-based workflows to make it easier to validate that the right image was used. Right now, one would have to trust that the docker image was named correctly or fish for that virtualized OS information deep down in build logs (assuming it can be found at all). This suggestion/request is outside this PR scope, of course.

Sure, I can do that in a followup PR touching "test-builds.sh"; I would not do it as part of the test harness: your point is valid and it makes sense to do it always.

In PR description, I fixed formatting, removed a statement that duplicated PR title, and provided a specific EOL date from Fedora 39 schedule.

Thanks

This will need to be backported to v6

Your call. To me, it feels like v6 (that will be itself EOL soon) should be tested against its contemporary environment (to the extend that is feasible, of course), even if that environment becomes obsolete from current time point of view.

I see benefit in standardising as much as possible on a single solution

@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels S-could-use-an-approval An approval may speed this PR merger (but is not required) backport-to-v6 maintainer has approved these changes for v6 backporting labels Oct 30, 2024
@rousskov
Copy link
Contributor

rousskov commented Oct 30, 2024

Thank you for providing a link to staging test results! BTW, I suggest adding something like cat /etc/issue and/or uname -a to the beginning of Linux docker-based workflows to make it easier to validate that the right image was used. Right now, one would have to trust that the docker image was named correctly or fish for that virtualized OS information deep down in build logs (assuming it can be found at all). This suggestion/request is outside this PR scope, of course.

Sure, I can do that in a followup PR touching "test-builds.sh"; I would not do it as part of the test harness: your point is valid and it makes sense to do it always.

I support adjusting test-builds.sh or even ./configure because that adjustment may be useful when folks share build logs from undisclosed or uncertain environments. Please be mindful of execution environments that lack /etc/issue. Thank you in advance for that followup PR!

This will need to be backported to v6

Your call. To me, it feels like v6 (that will be itself EOL soon) should be tested against its contemporary environment (to the extend that is feasible, of course), even if that environment becomes obsolete from current time point of view.

I see benefit in standardising as much as possible on a single solution

This is not about an existence of some benefit. It is about balancing multiple benefits and harms. While it is always possible to drop or add test platforms (or even stop testing!), I see more harm from not testing on a likely deployment target than benefit from using the same set of targets for all Squid versions (i.e. the coveted "single solution"). For v6, a likely deployment targets probably include Fedora 39 (unless we are going to make an argument that we should not have tested v6+ on Fedora 39 to begin with).

squid-anubis pushed a commit that referenced this pull request Nov 1, 2024
Fedora 39 will become EOL on 2024-11-12. Fedora 41 has been released.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Nov 1, 2024
@rousskov rousskov removed the S-could-use-an-approval An approval may speed this PR merger (but is not required) label Nov 1, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Nov 1, 2024
squidadm pushed a commit to squidadm/squid that referenced this pull request Nov 1, 2024
Fedora 39 will become EOL on 2024-11-12. Fedora 41 has been released.
kinkie added a commit that referenced this pull request Nov 1, 2024
Fedora 39 will become EOL on 2024-11-12. Fedora 41 has been released.
@squidadm squidadm removed the backport-to-v6 maintainer has approved these changes for v6 backporting label Nov 2, 2024
@squidadm
Copy link
Collaborator

squidadm commented Nov 2, 2024

queued for backport to v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants