-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sBTC] 3553 add burn ops rpc for pegout #3576
[sBTC] 3553 add burn ops rpc for pegout #3576
Conversation
…nto feat/sbtc-burn-ops-rpc
…rmats [sBTC] Feat: Peg-in operation wire format
Codecov Report
@@ Coverage Diff @@
## 3553-add-burn-ops-rpc-for-pegout-prerequisits #3576 +/- ##
================================================================================
Coverage ? 27.93%
================================================================================
Files ? 309
Lines ? 277756
Branches ? 0
================================================================================
Hits ? 77595
Misses ? 200161
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@kantai do we have any tests for API responses? This diff seems suspiciously small and that's the only thing that crossed my mind, so I might've missed it. Also, let me know if you find that something is missing. |
We also should extend the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me. One request, can we add a serialization test similar to what Aaron added here https://github.com/stacks-network/stacks-blockchain/pull/3511/files#diff-0cc1d8499a6219cd0467abfddd7ae0eb6e5269b10df975cf68d79b35d70867e4?
I'll need to create another prereq branch from the latest parent branches:
|
Co-authored-by: Jude Nelson <[email protected]>
…eg ops Co-authored-by: Jude Nelson <[email protected]>
855470e
to
181dac8
Compare
If it's for sBTC, please label it as such. Thanks! |
Done. This is to be incorporated in #3577 since the changes introduced here are minimal and closely related to it. I'm closing this PR since we don't intend to merge this one. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Uses a temporary branch as a base until some prerequisite work is merged into next.
Applicable issues
Checklist