-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sBTC] Feat: Peg out request & fulfillment wire formats & RPC #3577
Conversation
Codecov Report
@@ Coverage Diff @@
## next #3577 +/- ##
==========================================
+ Coverage 27.28% 30.94% +3.66%
==========================================
Files 305 308 +3
Lines 276796 277692 +896
==========================================
+ Hits 75513 85936 +10423
+ Misses 201283 191756 -9527
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
testnet/stacks-node/src/burnchains/bitcoin_regtest_controller.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. Still have a wrong payment calculation.
1f4594b
to
e01cf64
Compare
Interesting. I've rebased and updated the payment calculation now. As mentioned in the sBTC meeting, I will add the changes from #3576 to this branch since that is such a small PR. Also, it logically makes sense to incorporate those changes here to get the full end-to-end implementation of the wire formats including RPC endpoints. I'll post here when it's done. Just awaiting @stjepangolemac to finish an update to the RPC PR before I cherry-pick. |
e01cf64
to
1f4594b
Compare
4aaf4d5
to
408ccdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, just had a comment on the documentation example.
Co-authored-by: Jude Nelson <[email protected]>
4ffe2ff
to
f4bea67
Compare
…eg ops Co-authored-by: Jude Nelson <[email protected]>
Co-authored-by: Stjepan Golemac <[email protected]> Co-authored-by: Mårten Blankfors <[email protected]>
f4bea67
to
bdd19ca
Compare
@jcnelson Everything is green now, we've got two approvals and I've resolved recent conflicts. Feel free to merge if things look good to you. |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Identical to #3510 except this is pointing directly to
next
.