Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sBTC] Feat: Peg out request & fulfillment wire formats & RPC #3577

Merged
merged 35 commits into from
Feb 23, 2023

Conversation

netrome
Copy link
Contributor

@netrome netrome commented Feb 17, 2023

Identical to #3510 except this is pointing directly to next.

@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #3577 (bdd19ca) into next (718a352) will increase coverage by 3.66%.
The diff coverage is 30.54%.

@@            Coverage Diff             @@
##             next    #3577      +/-   ##
==========================================
+ Coverage   27.28%   30.94%   +3.66%     
==========================================
  Files         305      308       +3     
  Lines      276796   277692     +896     
==========================================
+ Hits        75513    85936   +10423     
+ Misses     201283   191756    -9527     
Impacted Files Coverage Δ
src/chainstate/burn/operations/peg_in.rs 23.47% <0.00%> (+23.47%) ⬆️
src/chainstate/burn/operations/test/mod.rs 0.00% <0.00%> (ø)
...c/chainstate/burn/operations/test/serialization.rs 0.00% <0.00%> (ø)
src/chainstate/coordinator/tests.rs 0.00% <0.00%> (ø)
src/net/mod.rs 18.72% <0.00%> (+0.83%) ⬆️
...t/stacks-node/src/burnchains/mocknet_controller.rs 68.31% <0.00%> (-3.55%) ⬇️
src/chainstate/burn/operations/peg_out_request.rs 22.41% <22.41%> (ø)
src/chainstate/burn/operations/peg_out_fulfill.rs 27.14% <27.14%> (ø)
src/chainstate/burn/db/processing.rs 54.64% <33.33%> (-0.16%) ⬇️
src/chainstate/burn/operations/mod.rs 39.31% <38.09%> (+28.47%) ⬆️
... and 99 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@sergey-shandar sergey-shandar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Still have a wrong payment calculation.

@netrome netrome force-pushed the 3493-sbtc-peg-out-wire-format branch from 1f4594b to e01cf64 Compare February 21, 2023 08:26
@netrome
Copy link
Contributor Author

netrome commented Feb 21, 2023

Almost there. Still have a wrong payment calculation.

Interesting. I've rebased and updated the payment calculation now. As mentioned in the sBTC meeting, I will add the changes from #3576 to this branch since that is such a small PR. Also, it logically makes sense to incorporate those changes here to get the full end-to-end implementation of the wire formats including RPC endpoints.

I'll post here when it's done. Just awaiting @stjepangolemac to finish an update to the RPC PR before I cherry-pick.

@netrome netrome force-pushed the 3493-sbtc-peg-out-wire-format branch 3 times, most recently from 4aaf4d5 to 408ccdc Compare February 21, 2023 14:58
@netrome netrome linked an issue Feb 21, 2023 that may be closed by this pull request
@netrome netrome requested a review from kantai February 21, 2023 18:37
@netrome
Copy link
Contributor Author

netrome commented Feb 21, 2023

This PR has now been updated to include the RPC changes. You can view the RPC changes in isolation here

@kantai and @jcnelson it would be great if you could have a look at this when you have time.

Copy link
Member

@kantai kantai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, just had a comment on the documentation example.

docs/rpc/api/core-node/get-burn-ops.example.json Outdated Show resolved Hide resolved
@netrome netrome force-pushed the 3493-sbtc-peg-out-wire-format branch from 4ffe2ff to f4bea67 Compare February 23, 2023 08:09
@netrome
Copy link
Contributor Author

netrome commented Feb 23, 2023

@jcnelson Everything is green now, we've got two approvals and I've resolved recent conflicts. Feel free to merge if things look good to you.

@jcnelson jcnelson merged commit 8d7ce23 into next Feb 23, 2023
@igorsyl igorsyl changed the title [sBTC] Feat: Peg out request & fulfillment wire formats [sBTC] Feat: Peg out request & fulfillment wire formats & RPC Feb 24, 2023
@igorsyl igorsyl linked an issue Mar 4, 2023 that may be closed by this pull request
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
Archived in project
Development

Successfully merging this pull request may close these issues.

Add burn ops RPC for PegOut [sBTC] Peg-out wire format
6 participants