Debug/dkg results #4660
Merged
Debug/dkg results #4660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just realized we should retarget this to develop. I will rebase and force push that change here. |
…nimize unnecessary DKG triggering Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
force-pushed
the
debug/dkg-results
branch
from
0598e6e
to
da120a8
Compare
xoloki
previously approved these changes
Apr 10, 2024
hstove
previously approved these changes
Apr 10, 2024
jcnelson
reviewed
Apr 10, 2024
kantai
previously approved these changes
Apr 12, 2024
hstove
previously approved these changes
Apr 16, 2024
|
@jferrant can you double check my conflict resolution in the last commit here? |
obycode
approved these changes
Apr 16, 2024
jferrant
commented
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needlessly were triggering DKG rounds due to a timing issue between our first check to see if a key was approved and the later threshold check being exceeded.
Now if we have not locally stored an approved key, we will always attempt the DKG queue checks. It will always follow this check by a final loading of whatever is set in the contract. Not bothering to queue a command if it finds an approved key. This should mitigate needless triggering of DKG for the obvious case.
However, we still need the later update to retrieve DKG shares based on round ID in #4654 as we can never be sure that our view of the contract is correct at the time of triggering a DKG round. (we could be milliseconds off when checking the approved key is set still).