WIP: Add block state and aggregate signature rejections #5140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacinta Ferrant <[email protected]>
jcnelson
reviewed
Sep 4, 2024
jcnelson
reviewed
Sep 4, 2024
…he same block Signed-off-by: Jacinta Ferrant <[email protected]>
…etwork/stacks-core into fix/5136-signer-block-state-tracking
jbencin
reviewed
Sep 4, 2024
Signed-off-by: Jacinta Ferrant <[email protected]>
|
To wrap this, I intend to merge this into |
test: fix `follower_bootup` integration test
Signed-off-by: Jacinta Ferrant <[email protected]>
…ortition being processed
….com/stacks-network/stacks-blockchain into fix/5136-signer-block-state-tracking
Signed-off-by: Jacinta Ferrant <[email protected]>
…integration tests Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…n opening the chainstate
….com/stacks-network/stacks-blockchain into fix/5136-signer-block-state-tracking
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…d use the highest tenure block from the chainstate to deduce where we should build (since it's not possible anymore to keep .mined_blocks coherent with the node's chainstate)
….com/stacks-network/stacks-core into fix/5136-signer-block-state-tracking
… test Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
…r-other-blocks fix: ignore rejections for other blocks in sign coordinator
jcnelson
approved these changes
Sep 9, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to add tests. This literally was my first brain dump with very little organization of thought.
Partially closes #5132
This also fixes a bug on the miner side which was incorrectly aggregating signer rejection weight (never checked if a signer had already sent a response or not)