Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Add block state and aggregate signature rejections #5140

Merged
merged 39 commits into from
Sep 9, 2024
Merged

WIP: Add block state and aggregate signature rejections #5140

merged 39 commits into from
Sep 9, 2024

Commits on Sep 4, 2024

  1. WIP: Add block state and aggregate signature rejections 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    af802a9 View commit details
    Browse the repository at this point in the history

  2. Fix miners to not accept multiple messages from the same signer for t… 

    …he same block

Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    33ec49a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/5136-node-and-miner' of https://github.com/stacks-n… 

    …etwork/stacks-core into fix/5136-signer-block-state-tracking
    @jferrant
    jferrant committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    9d622f3 View commit details
    Browse the repository at this point in the history

  4. test: fix follower_bootup integration test

    @obycode
    obycode committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b675546 View commit details
    Browse the repository at this point in the history

  5. WIP: broken check_proposal reorg timing test 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    0ec5688 View commit details
    Browse the repository at this point in the history

  6. fix: fix block proposal integration test

    @jcnelson
    jcnelson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f34c741 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'fix/5136-node-and-miner' into fix/5136-signer-block-sta… 

    …te-tracking
    @jcnelson
    jcnelson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    fa4cd9b View commit details
    Browse the repository at this point in the history

  8. chore: address PR feedback

    @jcnelson
    jcnelson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    3047b5f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge pull request #5143 from stacks-network/fix/follower_bootup 

    test: fix `follower_bootup` integration test
    @jbencin
    jbencin authored Sep 5, 2024
    Configuration menu
    Copy the full SHA
    457afc0 View commit details
    Browse the repository at this point in the history

  2. chore: fix get_block_state() and add a unit test

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5487b65 View commit details
    Browse the repository at this point in the history

  3. Add a log to block miner thread stopping 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5988c65 View commit details
    Browse the repository at this point in the history

  4. chore: documentation

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9afe92e View commit details
    Browse the repository at this point in the history

  5. chore: test_debug --> debug

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9e5e389 View commit details
    Browse the repository at this point in the history

  6. chore: raise initiative on miner failure, in case it's due to a new s… 

    …ortition being processed
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    8f2b2e7 View commit details
    Browse the repository at this point in the history

  7. chore: log joined miner thread error

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    e1d7f6e View commit details
    Browse the repository at this point in the history

  8. fix: abort signer waiting if the tenure changes, but only after a tim… 

    …eout has passed
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bbdfc66 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'fix/5136-signer-block-state-tracking' of https://github… 

    ….com/stacks-network/stacks-blockchain into fix/5136-signer-block-state-tracking
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bb4fafe View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' of https://github.com/stacks-network/stacks-bl… 

    …ockchain into develop
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    ce80740 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'develop' into fix/5136-signer-block-state-tracking

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9f69e03 View commit details
    Browse the repository at this point in the history

  12. fix: fix failing follower bootup test

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7f0a1f3 View commit details
    Browse the repository at this point in the history

  13. Fix check_proposal_reorg_ok test 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    343dc31 View commit details
    Browse the repository at this point in the history

  14. add allow_reorg_locally_accepted_block_if_globally_rejected_succeeds … 

    …integration tests

Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5833a8f View commit details
    Browse the repository at this point in the history

  15. Fix test description 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7d6902f View commit details
    Browse the repository at this point in the history

  16. chore: fix potential deadlock condition by avoiding a transaction whe… 

    …n opening the chainstate
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    baee54e View commit details
    Browse the repository at this point in the history

  17. Merge branch 'fix/5136-signer-block-state-tracking' of https://github… 

    ….com/stacks-network/stacks-blockchain into fix/5136-signer-block-state-tracking
    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d9f4a4d View commit details
    Browse the repository at this point in the history

  18. chore: fmt

    @jcnelson
    jcnelson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    db88eb8 View commit details
    Browse the repository at this point in the history

  19. Add locally_rejected_nlocks_overriden_by_global_acceptance test 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7217594 View commit details
    Browse the repository at this point in the history

  20. Do not store blocks that fail the initial checks 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    cfd2c37 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Fix broken build from prior db change commit 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    2be05f9 View commit details
    Browse the repository at this point in the history

  2. chore: remove .mined_blocks and replace it with .last_mined_block, an… 

    …d use the highest tenure block from the chainstate to deduce where we should build (since it's not possible anymore to keep .mined_blocks coherent with the node's chainstate)
    @jcnelson
    jcnelson committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    1a1b076 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'fix/5136-signer-block-state-tracking' of https://github… 

    ….com/stacks-network/stacks-core into fix/5136-signer-block-state-tracking
    @jcnelson
    jcnelson committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ac4c047 View commit details
    Browse the repository at this point in the history

  4. Add reorg_locally_accepted_blocks_across_tenures_succeeds integration… 

    … test

Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a19af95 View commit details
    Browse the repository at this point in the history

  5. fix: ignore rejections for other blocks in sign coordinator

    @obycode
    obycode committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    025cc0d View commit details
    Browse the repository at this point in the history

  6. Add miner_recovers_when_broadcast_block_delay_across_tenures_occurs 

    Signed-off-by: Jacinta Ferrant <[email protected]>
    @jferrant
    jferrant committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ed3486c View commit details
    Browse the repository at this point in the history

  7. Merge pull request #5150 from stacks-network/fix/ignore-rejections-fo… 

    …r-other-blocks

fix: ignore rejections for other blocks in sign coordinator
    @jferrant
    jferrant authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    6673113 View commit details
    Browse the repository at this point in the history

  8. fix: make a stackerdb shrink if its signer list becomes smaller than … 

    …that in the DB
    @jcnelson
    jcnelson committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    55d2f32 View commit details
    Browse the repository at this point in the history

  9. fix: get miner_recovers_when_broadcast_block_delay_across_tenures_occ… 

    …urs to pass
    @jcnelson
    jcnelson committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    bb40d1a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. chore: a NetworkResult has data if it has an uploaded Nakamoto block

    @jcnelson
    jcnelson committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    17aa1c4 View commit details
    Browse the repository at this point in the history

  2. fix: compiler error (forgot self.)

    @jcnelson
    jcnelson committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    835e39b View commit details
    Browse the repository at this point in the history