Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Loss StarknetChainID #1223

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

BenFaruna
Copy link

@BenFaruna BenFaruna commented Sep 10, 2024

Motivation and Resolution

Users can set any custom L2/L3 chain ID
...

RPC version (if applicable)

...

Usage related changes

  • Change 1.
  • ...

Development related changes

  • Change 1.
  • Changes in the chainId type from StarknetChainId to ChainId

Checklist:

  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked the issues which this PR resolves
  • Documented the changes in code (API docs will be generated automatically)
  • Updated the tests
  • All tests are passing

@BenFaruna BenFaruna changed the title WIP: Loss StarknetChainID WIP: Loss StarknetChainID #1081 Sep 10, 2024
@BenFaruna BenFaruna changed the title WIP: Loss StarknetChainID #1081 WIP: Loss StarknetChainID Sep 10, 2024
@BenFaruna
Copy link
Author

#1081
@ivpavici Changing the chain ID type from StarkentChainId has a ripple effect

image

About 15 files will need to be updated. Please let me know how you'd want me to move forward.

@ivpavici
Copy link
Collaborator

@BenFaruna yeah go for it!

@BenFaruna
Copy link
Author

@ivpavici I have made the change to the codebase and substituted StarknetChainId for ChainId.
image

The image above shows the result after running the tests. It's the same result I've been getting before I started making any changes. Please review the change and let me know if I need to make any extra changes to the codebase.

@BenFaruna
Copy link
Author

GM @ivpavici
Can I change this from a draft PR so it can be reviewed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants