WIP: Loss StarknetChainID #1223
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| import { NetworkName } from '../../constants'; | ||
| import { BlockIdentifier, ChainId } from '../lib'; | ||
|
|
||
| export interface ProviderOptions extends RpcProviderOptions {} | ||
|
|
||
|
|
@@ -9,7 +9,7 @@ export type RpcProviderOptions = { | |
| transactionRetryIntervalFallback?: number; | ||
| headers?: object; | ||
| blockIdentifier?: BlockIdentifier; | ||
| chainId?: ChainId; | ||
| specVersion?: string; | ||
| default?: boolean; | ||
| waitMode?: boolean; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,8 @@ | ||
| import { ETransactionVersion, ETransactionVersion2, ETransactionVersion3 } from './api'; | ||
| import { | ||
| BigNumberish, | ||
| CairoVersion, | ||
| ChainId, | ||
| DeployAccountContractPayload, | ||
| InvocationsDetails, | ||
| V3TransactionDetails, | ||
|
|
@@ -16,7 +16,7 @@ export type InvocationsSignerDetails = (V2InvocationsSignerDetails | V3Invocatio | |
| export type V2InvocationsSignerDetails = { | ||
| walletAddress: string; | ||
| cairoVersion: CairoVersion; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| maxFee: BigNumberish; | ||
| version: `${ETransactionVersion2}`; | ||
|
|
@@ -25,7 +25,7 @@ export type V2InvocationsSignerDetails = { | |
| export type V3InvocationsSignerDetails = V3TransactionDetails & { | ||
| walletAddress: string; | ||
| cairoVersion: CairoVersion; | ||
| chainId: ChainId; | ||
| version: `${ETransactionVersion3}`; | ||
| }; | ||
|
|
||
|
|
@@ -37,15 +37,15 @@ export type V2DeclareSignerDetails = Required<InvocationsDetails> & { | |
| classHash: string; | ||
| compiledClassHash?: string; | ||
| senderAddress: string; | ||
| chainId: ChainId; | ||
| version: `${ETransactionVersion2}`; | ||
| }; | ||
|
|
||
| export type V3DeclareSignerDetails = V3TransactionDetails & { | ||
| classHash: string; | ||
| compiledClassHash: string; | ||
| senderAddress: string; | ||
| chainId: ChainId; | ||
| version: `${ETransactionVersion3}`; | ||
| }; | ||
|
|
||
|
|
@@ -56,13 +56,13 @@ export type DeployAccountSignerDetails = | |
| export type V2DeployAccountSignerDetails = Required<DeployAccountContractPayload> & | ||
| Required<InvocationsDetails> & { | ||
| contractAddress: BigNumberish; | ||
| chainId: ChainId; | ||
| version: `${ETransactionVersion2}`; | ||
| }; | ||
|
|
||
| export type V3DeployAccountSignerDetails = Required<DeployAccountContractPayload> & | ||
| V3TransactionDetails & { | ||
| contractAddress: BigNumberish; | ||
| chainId: ChainId; | ||
| version: `${ETransactionVersion3}`; | ||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,8 +13,7 @@ const guard = { | |
| isBN: (data: Record<string, any>, type: Record<string, any>, key: string) => { | ||
| if (!isBigInt(data[key])) | ||
| throw new Error( | ||
| `Data and formatter mismatch on ${key}:${type[key]}, expected response data ${key}:${data[key] | ||
| } to be BN instead it is ${typeof data[key]}` | ||
| ); | ||
| }, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,7 @@ | |
| * Transaction Hash based on Transaction Version | ||
| */ | ||
|
|
||
| import { BigNumberish, Calldata, ChainId } from '../../../types'; | ||
| import { | ||
| EDAMode, | ||
| ETransactionVersion, | ||
|
|
@@ -38,15 +37,15 @@ type CalcV2InvokeTxHashArgs = { | |
| version: `${ETransactionVersion2}`; | ||
| compiledCalldata: Calldata; | ||
| maxFee: BigNumberish; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| }; | ||
|
|
||
| type CalcV3InvokeTxHashArgs = { | ||
| senderAddress: BigNumberish; | ||
| version: `${ETransactionVersion3}`; | ||
| compiledCalldata: Calldata; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| accountDeploymentData: BigNumberish[]; | ||
| nonceDataAvailabilityMode: EDAMode; | ||
|
|
@@ -96,7 +95,7 @@ type CalcV2DeclareTxHashArgs = { | |
| senderAddress: BigNumberish; | ||
| version: `${ETransactionVersion2}`; | ||
| maxFee: BigNumberish; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| compiledClassHash?: string; | ||
| }; | ||
|
|
@@ -106,7 +105,7 @@ type CalcV3DeclareTxHashArgs = { | |
| compiledClassHash: string; | ||
| senderAddress: BigNumberish; | ||
| version: `${ETransactionVersion3}`; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| accountDeploymentData: BigNumberish[]; | ||
| nonceDataAvailabilityMode: EDAMode; | ||
|
|
@@ -164,7 +163,7 @@ type CalcV2DeployAccountTxHashArgs = { | |
| salt: BigNumberish; | ||
| version: `${ETransactionVersion2}`; | ||
| maxFee: BigNumberish; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| }; | ||
|
|
||
|
|
@@ -174,7 +173,7 @@ type CalcV3DeployAccountTxHashArgs = { | |
| compiledConstructorCalldata: Calldata; | ||
| salt: BigNumberish; | ||
| version: `${ETransactionVersion3}`; | ||
| chainId: ChainId; | ||
| nonce: BigNumberish; | ||
| nonceDataAvailabilityMode: EDAMode; | ||
| feeDataAvailabilityMode: EDAMode; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| /* eslint-disable no-param-reassign */ | ||
| /* eslint-disable import/extensions */ | ||
| import { StarknetChainId, TransactionHashPrefix } from '../../../constants'; | ||
| import { BigNumberish, ChainId, RawCalldata } from '../../../types'; | ||
| import { starkCurve } from '../../ec'; | ||
| import { toBigInt } from '../../num'; | ||
| import { getSelector } from '../selector'; | ||
|
|
@@ -33,7 +33,7 @@ export function calculateTransactionHashCommon( | |
| entryPointSelector: BigNumberish, | ||
| calldata: RawCalldata, | ||
| maxFee: BigNumberish, | ||
| chainId: ChainId, | ||
| additionalData: BigNumberish[] = [] | ||
| ): string { | ||
| const calldataHash = computeHashOnElements(calldata); | ||
|
|
@@ -61,7 +61,7 @@ export function calculateDeclareTransactionHash( | |
| senderAddress: BigNumberish, | ||
| version: BigNumberish, | ||
| maxFee: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish, | ||
| compiledClassHash?: string | ||
| ): string { | ||
|
|
@@ -88,7 +88,7 @@ export function calculateDeployAccountTransactionHash( | |
| salt: BigNumberish, | ||
| version: BigNumberish, | ||
| maxFee: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish | ||
| ) { | ||
| const calldata = [classHash, salt, ...constructorCalldata]; | ||
|
|
@@ -114,7 +114,7 @@ export function calculateTransactionHash( | |
| version: BigNumberish, | ||
| calldata: RawCalldata, | ||
| maxFee: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish | ||
| ): string { | ||
| return calculateTransactionHashCommon( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,8 @@ | |
|
|
||
| import { poseidonHashMany } from '@scure/starknet'; | ||
|
|
||
| import { TransactionHashPrefix } from '../../../constants'; | ||
| import { BigNumberish, Calldata, ChainId } from '../../../types'; | ||
| import { EDAMode, ResourceBounds } from '../../../types/api'; | ||
| import { toHex } from '../../num'; | ||
| import { encodeShortString } from '../../shortString'; | ||
|
|
@@ -42,7 +42,7 @@ export function calculateTransactionHashCommon( | |
| txHashPrefix: TransactionHashPrefix, | ||
| version: BigNumberish, | ||
| senderAddress: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish, | ||
| tip: BigNumberish, | ||
| paymasterData: BigNumberish[], | ||
|
|
@@ -77,7 +77,7 @@ export function calculateDeployAccountTransactionHash( | |
| compiledConstructorCalldata: Calldata, | ||
| salt: BigNumberish, | ||
| version: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish, | ||
| nonceDataAvailabilityMode: EDAMode, | ||
| feeDataAvailabilityMode: EDAMode, | ||
|
|
@@ -109,7 +109,7 @@ export function calculateDeclareTransactionHash( | |
| compiledClassHash: string, | ||
| senderAddress: BigNumberish, | ||
| version: BigNumberish, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish, | ||
| accountDeploymentData: BigNumberish[], | ||
| nonceDataAvailabilityMode: EDAMode, | ||
|
|
@@ -141,7 +141,7 @@ export function calculateInvokeTransactionHash( | |
| senderAddress: BigNumberish, | ||
| version: BigNumberish, | ||
| compiledCalldata: Calldata, | ||
| chainId: ChainId, | ||
| nonce: BigNumberish, | ||
| accountDeploymentData: BigNumberish[], | ||
| nonceDataAvailabilityMode: EDAMode, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the cast can be removed. Also for
rpc_0_7.